Split MirrorsData methods and MirrorsDataImpl data by element kind.

pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter.program_builder;
 
 /**
  * [member] is a field (instance, static, or top level).
  *
  * [name] is the field name that the [Namer] has picked for this field's
  * storage, that is, the JavaScript property name.
  *
  * [accessorName] is the name of the accessor. For instance fields this is
  * mostly the same as [name] except when [member] is shadowing a field in its
  * superclass.  For other fields, they are rarely the same.
  *
  * [needsGetter] and [needsSetter] represent if a getter or a setter
  * respectively is needed.  There are many factors in this, for example, if the
  * accessor can be inlined.
  *
  * [needsCheckedSetter] indicates that a checked getter is needed, and in this
  * case, [needsSetter] is always false. [needsCheckedSetter] is only true when
  * type assertions are enabled (checked mode).
  */
-typedef void AcceptField(
-    VariableElement member,
-    js.Name name,
-    js.Name accessorName,
-    bool needsGetter,
-    bool needsSetter,
-    bool needsCheckedSetter);
+typedef void AcceptField(FieldEntity member, js.Name name, js.Name accessorName,
+    bool needsGetter, bool needsSetter, bool needsCheckedSetter);
 
 class FieldVisitor {
   final Compiler compiler;
   final Namer namer;
   final ClosedWorld closedWorld;
 
   JavaScriptBackend get backend => compiler.backend;
 
   FieldVisitor(this.compiler, this.namer, this.closedWorld);
 
@@ skipping 85 matching lines @@
 
       // If a class is not instantiated then we add the field just so we can
       // generate the field getter/setter dynamically. Since this is only
       // allowed on fields that are in [element] we don't need to visit
       // superclasses for non-instantiated classes.
       cls.implementation.forEachInstanceField(visitField,
           includeSuperAndInjectedMembers: isInstantiated);
     }
   }
 
-  bool fieldNeedsGetter(VariableElement field) {
+  bool fieldNeedsGetter(FieldElement field) {
     assert(field.isField);
     if (fieldAccessNeverThrows(field)) return false;
     if (backend.mirrorsData.shouldRetainGetter(field)) return true;
     return field.isClassMember &&
         compiler.codegenWorldBuilder.hasInvokedGetter(field, closedWorld);
   }
 
-  bool fieldNeedsSetter(VariableElement field) {
+  bool fieldNeedsSetter(FieldElement field) {
     assert(field.isField);
     if (fieldAccessNeverThrows(field)) return false;
     if (field.isFinal || field.isConst) return false;
     if (backend.mirrorsData.shouldRetainSetter(field)) return true;
     return field.isClassMember &&
         compiler.codegenWorldBuilder.hasInvokedSetter(field, closedWorld);
   }
 
   static bool fieldAccessNeverThrows(VariableElement field) {
     return
         // We never access a field in a closure (a captured variable) without
         // knowing that it is there.  Therefore we don't need to use a getter
         // (that will throw if the getter method is missing), but can always
         // access the field directly.
         field is ClosureFieldElement;
   }
 
   bool canAvoidGeneratedCheckedSetter(VariableElement member) {
     // We never generate accessors for top-level/static fields.
     if (!member.isInstanceMember) return true;
     ResolutionDartType type = member.type;
     return type.treatAsDynamic || type.isObject;
   }
 }