Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2223)

Unified Diff: tests/compiler/dart2js/mirrors_used_test.dart

Issue 2791263005: Split MirrorsData methods and MirrorsDataImpl data by element kind. (Closed)
Patch Set: Updated cf. comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/util/emptyset.dart ('k') | tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/mirrors_used_test.dart
diff --git a/tests/compiler/dart2js/mirrors_used_test.dart b/tests/compiler/dart2js/mirrors_used_test.dart
index f7ba582be6965c8f97ac146b82274cce4644e274..73634227f530e7f09e116e7d883117d56fe8fe3e 100644
--- a/tests/compiler/dart2js/mirrors_used_test.dart
+++ b/tests/compiler/dart2js/mirrors_used_test.dart
@@ -108,19 +108,33 @@ void main() {
for (var library in compiler.libraryLoader.libraries) {
library.forEachLocalMember((member) {
- if (library == compiler.mainApp && member.name == 'Foo') {
- Expect.isTrue(
- compiler.backend.mirrorsData.isAccessibleByReflection(member),
- '$member');
- member.forEachLocalMember((classMember) {
+ if (member.isClass) {
+ if (library == compiler.mainApp && member.name == 'Foo') {
Expect.isTrue(
compiler.backend.mirrorsData
- .isAccessibleByReflection(classMember),
- '$classMember');
- });
+ .isClassAccessibleByReflection(member),
+ '$member');
+ member.forEachLocalMember((classMember) {
+ Expect.isTrue(
+ compiler.backend.mirrorsData
+ .isMemberAccessibleByReflection(classMember),
+ '$classMember');
+ });
+ } else {
+ Expect.isFalse(
+ compiler.backend.mirrorsData
+ .isClassAccessibleByReflection(member),
+ '$member');
+ }
+ } else if (member.isTypedef) {
+ Expect.isFalse(
+ compiler.backend.mirrorsData
+ .isTypedefAccessibleByReflection(member),
+ '$member');
} else {
Expect.isFalse(
- compiler.backend.mirrorsData.isAccessibleByReflection(member),
+ compiler.backend.mirrorsData
+ .isMemberAccessibleByReflection(member),
'$member');
}
});
« no previous file with comments | « pkg/compiler/lib/src/util/emptyset.dart ('k') | tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698