Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2791223003:
MD Settings: consolidate .no-outline css rules. (Closed)
|
Created:
3 years, 8 months ago by scottchen Modified:
3 years, 8 months ago CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: consolidate .no-outline css rules.
Consolidate all the scattered .no-outline rules into the shared stylesheet. Also make .no-outline class less opinionated about cursor style.
BUG=707646
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2791223003
Cr-Commit-Position: refs/heads/master@{#462226}
Committed: https://chromium.googlesource.com/chromium/src/+/f48cfe0d615d484ecefab7a780b640b0bba5e1b3
Patch Set 1 #
Total comments: 9
Patch Set 2 : move css rule to two lines #
Total comments: 2
Patch Set 3 : merge #
Messages
Total messages: 25 (13 generated)
Description was changed from ========== MD Settings: consolidate .no-outline css rules. Consolidate all the scattered .no-outline rules into the shared stylesheet. Also make .no-outline class less opinionated about cursor style. BUG=707646 ========== to ========== MD Settings: consolidate .no-outline css rules. Consolidate all the scattered .no-outline rules into the shared stylesheet. Also make .no-outline class less opinionated about cursor style. BUG=707646 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
scottchen@chromium.org changed reviewers: + dpapad@chromium.org
https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/on_startup_page/startup_urls_page.html (left): https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/on_startup_page/startup_urls_page.html:27: background: none; This will now be taken care of by the .no-outline rule. The .no-outline class will be added by FocusRowBehavior. https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/search_engines_page/search_engine_entry.html (left): https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/search_engines_page/search_engine_entry.html:45: outline: none; redundant rule. https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (left): https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:309: cursor: initial; .no-outline class should just be about outline. Inheriting elements who need to customize cursor can do it themselves.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (left): https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:309: cursor: initial; and also this was out of order :( https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:306: .no-outline, [scrollable] .no-outline { somehow none of this CSS seems to be checked by our tooling, because the style guide asks for selectors on multiple lines
https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (left): https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:309: cursor: initial; On 2017/04/03 19:51:34, Dan Beam (slow) wrote: > and also this was out of order :( Acknowledged. https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:306: .no-outline, [scrollable] .no-outline { On 2017/04/03 19:51:34, Dan Beam (slow) wrote: > somehow none of this CSS seems to be checked by our tooling, because the style > guide asks for selectors on multiple lines Done.
https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:306: .no-outline, [scrollable] .no-outline { On 2017/04/03 at 23:32:44, scottchen wrote: > On 2017/04/03 19:51:34, Dan Beam (slow) wrote: > > somehow none of this CSS seems to be checked by our tooling, because the style > > guide asks for selectors on multiple lines > > Done. Maybe the presubmit checks don't find CSS inside HTML files? Or at least not inside Polymer <dom-module> tags? https://codereview.chromium.org/2791223003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2791223003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_shared_css.html:307: [scrollable] .no-outline { Isn't "[scrollable] .no-outline" redundant here?
https://codereview.chromium.org/2791223003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2791223003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_shared_css.html:307: [scrollable] .no-outline { On 2017/04/03 23:45:50, dpapad wrote: > Isn't "[scrollable] .no-outline" redundant here? There are other "[scrollable] .something" rules that are considered more specific than .no-outline, so this is necessary to override those.
lgtm
https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/2791223003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_shared_css.html:306: .no-outline, [scrollable] .no-outline { On 2017/04/03 23:45:50, dpapad wrote: > On 2017/04/03 at 23:32:44, scottchen wrote: > > On 2017/04/03 19:51:34, Dan Beam (slow) wrote: > > > somehow none of this CSS seems to be checked by our tooling, because the > style > > > guide asks for selectors on multiple lines > > > > Done. > > Maybe the presubmit checks don't find CSS inside HTML files? Or at least not > inside Polymer <dom-module> tags? i fixted it https://codereview.chromium.org/2792193003/
lgtm
The CQ bit was checked by scottchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by scottchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scottchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org, dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2791223003/#ps40001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491427616531090,
"parent_rev": "86c244de4a1c3bdd813c0874cef2e31d9cb29ee7", "commit_rev":
"f48cfe0d615d484ecefab7a780b640b0bba5e1b3"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: consolidate .no-outline css rules. Consolidate all the scattered .no-outline rules into the shared stylesheet. Also make .no-outline class less opinionated about cursor style. BUG=707646 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: consolidate .no-outline css rules. Consolidate all the scattered .no-outline rules into the shared stylesheet. Also make .no-outline class less opinionated about cursor style. BUG=707646 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2791223003 Cr-Commit-Position: refs/heads/master@{#462226} Committed: https://chromium.googlesource.com/chromium/src/+/f48cfe0d615d484ecefab7a780b6... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f48cfe0d615d484ecefab7a780b6... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
