Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Side by Side Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2791223003: MD Settings: consolidate .no-outline css rules. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/shared_style_css.html"> 1 <link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
2 <link rel="import" href="settings_vars_css.html"> 2 <link rel="import" href="settings_vars_css.html">
3 3
4 <!-- Common styles for Material Design settings. --> 4 <!-- Common styles for Material Design settings. -->
5 <dom-module id="settings-shared"> 5 <dom-module id="settings-shared">
6 <template> 6 <template>
7 <style include="cr-shared-style"> 7 <style include="cr-shared-style">
8 /* Included here so we don't have to include "iron-positioning" in every 8 /* Included here so we don't have to include "iron-positioning" in every
9 * stylesheet. See crbug.com/498405. */ 9 * stylesheet. See crbug.com/498405. */
10 [hidden] { 10 [hidden] {
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 .settings-box .start.two-line { 296 .settings-box .start.two-line {
297 display: flex; 297 display: flex;
298 } 298 }
299 299
300 /* The start (left in LTR) part (horizontally) of a row. */ 300 /* The start (left in LTR) part (horizontally) of a row. */
301 .settings-box .start { 301 .settings-box .start {
302 align-items: center; 302 align-items: center;
303 flex: auto; 303 flex: auto;
304 } 304 }
305 305
306 [scrollable] .no-outline { 306 .no-outline, [scrollable] .no-outline {
Dan Beam 2017/04/03 19:51:34 somehow none of this CSS seems to be checked by ou
scottchen 2017/04/03 23:32:44 Done.
dpapad 2017/04/03 23:45:50 Maybe the presubmit checks don't find CSS inside H
Dan Beam 2017/04/04 19:54:55 i fixted it https://codereview.chromium.org/279219
307 background: none; 307 background: none;
308 outline: none; 308 outline: none;
309 cursor: initial;
scottchen 2017/04/03 18:22:23 .no-outline class should just be about outline. In
Dan Beam 2017/04/03 19:51:34 and also this was out of order :(
scottchen 2017/04/03 23:32:44 Acknowledged.
310 } 309 }
311 310
312 /* The secondary-action wraps a clickable sub-area of a .settings-box. 311 /* The secondary-action wraps a clickable sub-area of a .settings-box.
313 * An example is the |sign out| button on the People settings. 312 * An example is the |sign out| button on the People settings.
314 * Here is an example with and without a secondary action box: 313 * Here is an example with and without a secondary action box:
315 * 314 *
316 * +-------------------------------------------------------+ 315 * +-------------------------------------------------------+
317 * | Main action area .settings-box | .secondary-action | 316 * | Main action area .settings-box | .secondary-action |
318 * +-------------------------------------------------------+ 317 * +-------------------------------------------------------+
319 * | Another setting-box without a secondary-action | 318 * | Another setting-box without a secondary-action |
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 transform: rotate(-135deg); 381 transform: rotate(-135deg);
383 } 382 }
384 383
385 .column-header { 384 .column-header {
386 color: var(--paper-grey-600); 385 color: var(--paper-grey-600);
387 font-weight: 500; 386 font-weight: 500;
388 } 387 }
389 </style> 388 </style>
390 </template> 389 </template>
391 </dom-module> 390 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698