Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2791213003: MIPS[64]: Support for some SIMD operations (6) (Closed)

Created:
3 years, 8 months ago by dusan.simicic
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Support for some SIMD operations (6) Add support for I16x8Mul, I16x8MaxS, I16x8MinS, I16x8Eq, I16x8Ne, I16x8LtS, I16x8LeS, I16x8AddSaturateU, I16x8SubSaturateU, I16x8MaxU, I16x8MinU, I16x8LtU, I16x8LeU, I8x16Splat, I8x16ExtractLane, I8x16ReplaceLane, I8x16Neg, I8x16Shl, I8x16ShrS, S16x8Select, S8x16Select for mips32 and mips64 architectures. BUG= Review-Url: https://codereview.chromium.org/2791213003 Cr-Commit-Position: refs/heads/master@{#45312} Committed: https://chromium.googlesource.com/v8/v8/+/b99a1ba0a66476ae22809694a1c218b250297aaf

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -28 lines) Patch
M src/compiler/instruction-selector.cc View 1 5 chunks +25 lines, -15 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 chunks +122 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 1 chunk +22 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 1 chunk +84 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 chunks +122 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 1 chunk +22 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 1 chunk +84 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 11 chunks +23 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
dusan.simicic
PTAL
3 years, 8 months ago (2017-04-04 12:28:01 UTC) #2
bbudge
lgtm
3 years, 8 months ago (2017-04-04 13:11:50 UTC) #3
dusan.simicic
+ bmeurer, + tebbi for instruction-selector.cc PTAL
3 years, 7 months ago (2017-05-09 09:36:51 UTC) #5
Benedikt Meurer
LGTM on the general compiler part.
3 years, 7 months ago (2017-05-09 10:51:29 UTC) #6
dusan.simicic
+ Miran for mips part
3 years, 7 months ago (2017-05-12 11:10:56 UTC) #8
ivica.bogosavljevic
MIPS part lgtm
3 years, 7 months ago (2017-05-15 14:51:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791213003/20001
3 years, 7 months ago (2017-05-15 15:44:29 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 15:46:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b99a1ba0a66476ae22809694a1c218b2502...

Powered by Google App Engine
This is Rietveld 408576698