Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties (Closed)
Patch Set: tidy up Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
index 0374b759a3b3ef3cfc532eff05b8bf688eb2dc64..c497051b17b0109a00783310ebadc694f765bd5d 100644
--- a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
@@ -86,15 +86,11 @@ CSSStyleValueVector InlineStylePropertyMap::getAllInternal(
}
CSSStyleValueVector InlineStylePropertyMap::getAllInternal(
- AtomicString customPropertyName) {
- const CSSValue* cssValue =
- m_ownerElement->ensureMutableInlineStyle().getPropertyCSSValue(
- customPropertyName);
- if (!cssValue)
- return CSSStyleValueVector();
-
- return StyleValueFactory::cssValueToStyleValueVector(CSSPropertyInvalid,
- *cssValue);
meade_UTC10 2017/04/06 03:47:32 It seems like removing this is moving backwards?
+ AtomicString customPropertyName,
+ ExceptionState& exceptionState) {
+ // TODO(rjwright/meade): Handle custom properties.
+ exceptionState.throwTypeError("Invalid propertyName: " + customPropertyName);
alancutter (OOO until 2018) 2017/04/05 04:54:09 Is this part still WIP for this patch?
+ return CSSStyleValueVector();
}
Vector<String> InlineStylePropertyMap::getProperties() {

Powered by Google App Engine
This is Rietveld 408576698