third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h - Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h

Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties (Closed)

Patch Set: tidy up Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp ('K') | « third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp ('k') | third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h

diff --git a/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h b/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h

index 9a60511969575146364f0920f2ff146c67f53de0..6d2200fa5a1a5f489911cf443fb9565ff25dfdf7 100644

--- a/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h

+++ b/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.h

@@ -41,8 +41,10 @@ class CORE_EXPORT StylePropertyMapReadonly

StylePropertyMapReadonly() = default;

virtual CSSStyleValueVector getAllInternal(CSSPropertyID) = 0;

- virtual CSSStyleValueVector getAllInternal(

- AtomicString customPropertyName) = 0;

+ // TODO(rjwright): Remove the ExceptionState arg once

+ // InlineStypePropertyMap::getAllInternal is implemented.

+ virtual CSSStyleValueVector getAllInternal(AtomicString customPropertyName,

+ ExceptionState&) = 0;

virtual HeapVector<StylePropertyMapEntry> getIterationEntries() = 0;

IterationSource* startIteration(ScriptState*, ExceptionState&) override;