[Typed CSSOM] New design for computed styles which includes custom properties

third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/InlineStylePropertyMap.h"
 
 #include "bindings/core/v8/Iterable.h"
 #include "core/CSSPropertyNames.h"
 #include "core/css/CSSCustomIdentValue.h"
 #include "core/css/CSSCustomPropertyDeclaration.h"
@@ skipping 68 matching lines @@
   const CSSValue* cssValue =
       m_ownerElement->ensureMutableInlineStyle().getPropertyCSSValue(
           propertyID);
   if (!cssValue)
     return CSSStyleValueVector();
 
   return StyleValueFactory::cssValueToStyleValueVector(propertyID, *cssValue);
 }
 
 CSSStyleValueVector InlineStylePropertyMap::getAllInternal(
-    AtomicString customPropertyName) {
-  const CSSValue* cssValue =
-      m_ownerElement->ensureMutableInlineStyle().getPropertyCSSValue(
-          customPropertyName);
-  if (!cssValue)
-    return CSSStyleValueVector();
-
-  return StyleValueFactory::cssValueToStyleValueVector(CSSPropertyInvalid,
-                                                       *cssValue);

[meade_UTC10, 2017/04/06 03:47:32]

It seems like removing this is moving backwards?

+    AtomicString customPropertyName,
+    ExceptionState& exceptionState) {
+  // TODO(rjwright/meade): Handle custom properties.
+  exceptionState.throwTypeError("Invalid propertyName: " + customPropertyName);

[alancutter (OOO until 2018), 2017/04/05 04:54:09]

Is this part still WIP for this patch?

+  return CSSStyleValueVector();
 }
 
 Vector<String> InlineStylePropertyMap::getProperties() {
   DEFINE_STATIC_LOCAL(const String, kAtApply, ("@apply"));
   Vector<String> result;
   bool containsAtApply = false;
   StylePropertySet& inlineStyleSet = m_ownerElement->ensureMutableInlineStyle();
   for (unsigned i = 0; i < inlineStyleSet.propertyCount(); i++) {
     CSSPropertyID propertyID = inlineStyleSet.propertyAt(i).id();
     if (propertyID == CSSPropertyVariable) {
@@ skipping 132 matching lines @@
         value.setCSSStyleValue(styleValueVector[0]);
       else
         value.setCSSStyleValueSequence(styleValueVector);
     }
     result.push_back(std::make_pair(name, value));
   }
   return result;
 }
 
 }  // namespace blink