[regexp] Throw on invalid capture group names in replacer string

[regexp] Throw on invalid capture group names in replacer string

References to invalid names (i.e. not specified as a named group in the
pattern) throw a SyntaxError. Unmatched groups are still replaced by the
empty string.

See https://github.com/tc39/proposal-regexp-named-groups/issues/14.

BUG=v8:5437
Review-Url: https://codereview.chromium.org/2791183002
Cr-Commit-Position: refs/heads/master@{#44471}
Committed: https://chromium.googlesource.com/v8/v8/+/1329d15e99096559a41ac7cb49fbd0199607a5d2

[jgruber, 2017-04-03 08:13:08]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 08:13:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-03 08:18:00]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 08:18:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-03 08:35:33]

jgruber@chromium.org changed reviewers:
+ littledan@chromium.org, yangguo@chromium.org

[jgruber, 2017-04-03 08:35:33]

https://codereview.chromium.org/2791183002/diff/1/src/runtime/runtime-regexp.cc
File src/runtime/runtime-regexp.cc (left):

https://codereview.chromium.org/2791183002/diff/1/src/runtime/runtime-regexp....
src/runtime/runtime-regexp.cc:78: EMPTY,
The empty replacement for unmatched captures is handled by SUBJECT_CAPTURE.

[commit-bot: I haz the power, 2017-04-03 08:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 08:49:09]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2017-04-06 18:13:09]

lgtm

AFAICT all of the paths here match the new specification.

[jgruber, 2017-04-07 07:43:54]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-04-07 07:43:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 08:32:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491551034837170,
"parent_rev": "e97b29a4c5741f11318416877fc43c3c8cea93a2", "commit_rev":
"1329d15e99096559a41ac7cb49fbd0199607a5d2"}

[commit-bot: I haz the power, 2017-04-07 08:32:52]

Description was changed from

==========
[regexp] Throw on invalid capture group names in replacer string

References to invalid names (i.e. not specified as a named group in the
pattern) throw a SyntaxError. Unmatched groups are still replaced by the
empty string.

See https://github.com/tc39/proposal-regexp-named-groups/issues/14.

BUG=v8:5437
==========

to

==========
[regexp] Throw on invalid capture group names in replacer string

References to invalid names (i.e. not specified as a named group in the
pattern) throw a SyntaxError. Unmatched groups are still replaced by the
empty string.

See https://github.com/tc39/proposal-regexp-named-groups/issues/14.

BUG=v8:5437

Review-Url: https://codereview.chromium.org/2791183002
Cr-Commit-Position: refs/heads/master@{#44471}
Committed:
https://chromium.googlesource.com/v8/v8/+/1329d15e99096559a41ac7cb49fbd019960...
==========

[commit-bot: I haz the power, 2017-04-07 08:32:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/1329d15e99096559a41ac7cb49fbd019960...