Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: src/runtime/runtime-strings.cc

Issue 2791183002: [regexp] Throw on invalid capture group names in replacer string (Closed)
Patch Set: Typo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-regexp.cc ('k') | test/mjsunit/harmony/regexp-named-captures.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-strings.cc
diff --git a/src/runtime/runtime-strings.cc b/src/runtime/runtime-strings.cc
index 6f21051891f665f34d05b67ea625fca299106a8c..1ef04ed467f66112cc7dd4dcdb978ba9716896be 100644
--- a/src/runtime/runtime-strings.cc
+++ b/src/runtime/runtime-strings.cc
@@ -41,8 +41,9 @@ RUNTIME_FUNCTION(Runtime_GetSubstitution) {
return match_; // Return arbitrary string handle.
}
MaybeHandle<String> GetNamedCapture(Handle<String> name,
- bool* capture_exists) override {
+ CaptureState* state) override {
UNREACHABLE();
+ *state = INVALID;
return MaybeHandle<String>();
}
« no previous file with comments | « src/runtime/runtime-regexp.cc ('k') | test/mjsunit/harmony/regexp-named-captures.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698