bindings: Explicitly pass ValueType to toImplArray

third_party/WebKit/Source/bindings/scripts/v8_types.py

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py
index 6e1cb2c556771bb86a1f4ad79bf19d1f4524aedd..a8dd9a4770595f157868bd41d3fc0189fdf8e8cd 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py
@@ -639,7 +639,16 @@ def v8_value_to_cpp_value_array_or_sequence(native_array_element_type, v8_value,
             vector_type = 'HeapVector'
         else:
             vector_type = 'Vector'
-        expression_format = 'toImplArray<%s<{cpp_type}>>({v8_value}, {index}, {isolate}, exceptionState)' % vector_type
+        if native_array_element_type.is_primitive_type:

[haraken, 2017/04/03 04:29:02]

Why do we need to limit this to primitive types?

[bashi, 2017/04/03 04:42:34]

Just to minimize the impact of changes to see if tests are passed. I'm planning
to remove this check :)

[bashi, 2017/04/03 05:06:25]

Looks like we need to improve coverage of native_value_traits_type_name() and
IDLTypes.h to remove this check (e.g. we need to support enums and any). Let me
address it in follow-up CLs.

[Raphael Kubo da Costa (rakuco), 2017/04/06 13:22:36]

(belatedly adding myself to the party)

Are you actively working on this at the moment? I'm also doing some changes to
this part of the code and stumbled upon the problems with enums & friends, but
if you already have a patch we can avoid crossing our streams.

+            value_type = native_value_traits_type_name(native_array_element_type)
+            expression_format = ('toImplArray<%s<{cpp_type}>, %s>'
+                                 '({v8_value}, {index}, {isolate}, '
+                                 'exceptionState)' % (vector_type, value_type))
+        else:
+            expression_format = ('toImplArray<%s<{cpp_type}>>'
+                                 '({v8_value}, {index}, {isolate}, '
+                                 'exceptionState)' % vector_type)
+
     expression = expression_format.format(native_array_element_type=native_array_element_type.name, cpp_type=this_cpp_type,
                                           index=index, v8_value=v8_value, isolate=isolate)
     return expression