[instrumentation] Introduce JSON5 config files for probe generator.

[instrumentation] Introduce JSON5 config files for probe generator.

BUG=695625
Review-Url: https://codereview.chromium.org/2790973002
Cr-Commit-Position: refs/heads/master@{#461926}
Committed: https://chromium.googlesource.com/chromium/src/+/4ed0890b65a8e6b9176085c97bdd2cc8efeff66a

[alph, 2017-03-31 18:37:50]

alph@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[alph, 2017-03-31 18:37:56]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 18:38:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 18:48:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 18:48:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dgozman, 2017-03-31 23:15:19]

Where are the config files though?

https://codereview.chromium.org/2790973002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py
(right):

https://codereview.chromium.org/2790973002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py:246:
sys.stderr.write("\t--config <config_file.json5>\n")
--template_dir ?

[alph, 2017-04-01 00:05:28]

ptal

https://codereview.chromium.org/2790973002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py
(right):

https://codereview.chromium.org/2790973002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py:246:
sys.stderr.write("\t--config <config_file.json5>\n")
On 2017/03/31 23:15:19, dgozman wrote:
> --template_dir ?

Done.

[alph, 2017-04-01 00:05:33]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-01 00:06:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-04-01 00:23:55]

lgtm

[alph, 2017-04-01 00:24:22]

The CQ bit was unchecked by alph@chromium.org

[alph, 2017-04-01 00:24:29]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-04-01 00:24:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-01 00:39:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-01 00:39:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alph, 2017-04-01 03:38:34]

Pavel, could you please take a look at platform/

[alph, 2017-04-04 18:26:02]

Friendly ping.
I still need an owner approval for platform/BUILD.gn

[pfeldman, 2017-04-04 19:04:12]

lgtm

[alph, 2017-04-04 19:04:27]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-04-04 19:05:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 22:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 22:55:09]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[alph, 2017-04-04 23:17:09]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-04-04 23:17:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 00:59:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491347829634090,
"parent_rev": "26b9dcec30000075deb5bf3455e99961c4db8b17", "commit_rev":
"4ed0890b65a8e6b9176085c97bdd2cc8efeff66a"}

[commit-bot: I haz the power, 2017-04-05 01:01:10]

Description was changed from

==========
[instrumentation] Introduce JSON5 config files for probe generator.

BUG=695625
==========

to

==========
[instrumentation] Introduce JSON5 config files for probe generator.

BUG=695625

Review-Url: https://codereview.chromium.org/2790973002
Cr-Commit-Position: refs/heads/master@{#461926}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ed0890b65a8e6b9176085c97bdd...
==========

[commit-bot: I haz the power, 2017-04-05 01:01:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ed0890b65a8e6b9176085c97bdd...