Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl

Issue 2790973002: [instrumentation] Introduce JSON5 config files for probe generator. (Closed)
Patch Set: add missing config files Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl
diff --git a/third_party/WebKit/Source/platform/probe/templates/InstrumentingProbesInl.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl
similarity index 84%
rename from third_party/WebKit/Source/platform/probe/templates/InstrumentingProbesInl.h.tmpl
rename to third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl
index db28b1dd4158a0bdd240dd5475476d05466c0a81..d525812339731788e616f3e852966a20e11dde47 100644
--- a/third_party/WebKit/Source/platform/probe/templates/InstrumentingProbesInl.h.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl
@@ -12,9 +12,7 @@
{{include}}
{% endfor %}
-{% for define in file.defines %}
-{{define}}
-{% endfor %}
+{% set export_symbol = config["settings"]["export_symbol"] %}
namespace blink {
@@ -37,7 +35,7 @@ namespace probe {
{% if probe.is_scoped %}
-class PROBE_EXPORT {{probe.name}} : public ProbeBase {
+class {{export_symbol}} {{probe.name}} : public ProbeBase {
STACK_ALLOCATED()
public:
explicit {{probe.name}}({{ params_decl(probe) }});
@@ -48,7 +46,7 @@ class PROBE_EXPORT {{probe.name}} : public ProbeBase {
};
{%- else %}
-PROBE_EXPORT {{probe.return_type}} {{probe.name}}({{ params_decl(probe) }});
+{{export_symbol}} {{probe.return_type}} {{probe.name}}({{ params_decl(probe) }});
{%- endif %}
{%- endfor %}

Powered by Google App Engine
This is Rietveld 408576698