Fix calculation of Password Generation popup.

Fix calculation of Password Generation popup.

A width of |password_view_| was not taken into consideration for calculation of width of Password Generation popup. Screenshoots how it looks like before and after fixes are on the bug.

This CL introduces, that width of Password Generation popup should be at least width of |password_view_| + borders.

BUG=707253
Review-Url: https://codereview.chromium.org/2790953002
Cr-Commit-Position: refs/heads/master@{#461415}
Committed: https://chromium.googlesource.com/chromium/src/+/f49d5b25ff568f099280ac9c285638f86efa7ea8

[dvadym, 2017-03-31 16:05:35]

Description was changed from

==========
Fix calculation of Password Generation popup.

BUG=707253
==========

to

==========
Fix calculation of Password Generation popup.

A width of |password_view_| was not taken into consideration for calculation of
width of Password Generation popup. Screenshoots how it looks like, when stings
were changed, are on the bug.

This CL introduces, that width of Password Generation popup should be at least
width of |password_view_| + borders.

BUG=707253
==========

[dvadym, 2017-03-31 16:06:02]

Description was changed from

==========
Fix calculation of Password Generation popup.

A width of |password_view_| was not taken into consideration for calculation of
width of Password Generation popup. Screenshoots how it looks like, when stings
were changed, are on the bug.

This CL introduces, that width of Password Generation popup should be at least
width of |password_view_| + borders.

BUG=707253
==========

to

==========
Fix calculation of Password Generation popup.

A width of |password_view_| was not taken into consideration for calculation of
width of Password Generation popup. Screenshoots how it looks like before and
after fixes are on the bug.

This CL introduces, that width of Password Generation popup should be at least
width of |password_view_| + borders.

BUG=707253
==========

[dvadym, 2017-03-31 16:11:21]

dvadym@chromium.org changed reviewers:
+ msw@chromium.org

[dvadym, 2017-03-31 16:11:21]

msw@, could you please review this CL?

Regards,
Vadym

[msw, 2017-03-31 16:38:26]

lgtm with an optional nit; thanks for the screenshots.

https://codereview.chromium.org/2790953002/diff/1/chrome/browser/ui/views/aut...
File chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc
(right):

https://codereview.chromium.org/2790953002/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc:180:
int height = kPopupBorderThickness;
optional nit: init height to just |help_label_->GetHeightForWidth(width)|,
remove the addition on line 189 and add |2 * kPopupBorderThickness| on line 191,
like line 190.

[dvadym, 2017-04-03 12:29:40]

Thanks for review!

https://codereview.chromium.org/2790953002/diff/1/chrome/browser/ui/views/aut...
File chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc
(right):

https://codereview.chromium.org/2790953002/diff/1/chrome/browser/ui/views/aut...
chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc:180:
int height = kPopupBorderThickness;
On 2017/03/31 16:38:26, msw wrote:
> optional nit: init height to just |help_label_->GetHeightForWidth(width)|,
> remove the addition on line 189 and add |2 * kPopupBorderThickness| on line
191,
> like line 190.

Done.

[dvadym, 2017-04-03 12:29:45]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2017-04-03 12:29:45]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2790953002/#ps20001
(title: "Nit")

[commit-bot: I haz the power, 2017-04-03 12:29:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 13:14:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491222585144490,
"parent_rev": "c09e3997a3688d11623054205f4b25e4f8e7dba7", "commit_rev":
"f49d5b25ff568f099280ac9c285638f86efa7ea8"}

[commit-bot: I haz the power, 2017-04-03 13:15:04]

Description was changed from

==========
Fix calculation of Password Generation popup.

A width of |password_view_| was not taken into consideration for calculation of
width of Password Generation popup. Screenshoots how it looks like before and
after fixes are on the bug.

This CL introduces, that width of Password Generation popup should be at least
width of |password_view_| + borders.

BUG=707253
==========

to

==========
Fix calculation of Password Generation popup.

A width of |password_view_| was not taken into consideration for calculation of
width of Password Generation popup. Screenshoots how it looks like before and
after fixes are on the bug.

This CL introduces, that width of Password Generation popup should be at least
width of |password_view_| + borders.

BUG=707253

Review-Url: https://codereview.chromium.org/2790953002
Cr-Commit-Position: refs/heads/master@{#461415}
Committed:
https://chromium.googlesource.com/chromium/src/+/f49d5b25ff568f099280ac9c2856...
==========

[commit-bot: I haz the power, 2017-04-03 13:15:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f49d5b25ff568f099280ac9c2856...