Fix calculation of Password Generation popup.

chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/password_generation_popup_view_views.h"
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "chrome/app/vector_icons/vector_icons.h"
 #include "chrome/browser/ui/autofill/password_generation_popup_controller.h"
@@ skipping 159 matching lines @@
   password_view_->Init(controller_->password(),
                        controller_->SuggestedText(),
                        font_list_);
   password_view_->SetPosition(gfx::Point(kPopupBorderThickness,
                                          kPopupBorderThickness));
   password_view_->SizeToPreferredSize();
   AddChildView(password_view_);
 }
 
 gfx::Size PasswordGenerationPopupViewViews::GetPreferredSizeOfPasswordView() {
   int height = kPopupBorderThickness;

[msw, 2017/03/31 16:38:26]

optional nit: init height to just |help_label_->GetHeightForWidth(width)|,
remove the addition on line 189 and add |2 * kPopupBorderThickness| on line 191,
like line 190.

[dvadym, 2017/04/03 12:29:39]

Done.

   if (controller_->display_password()) {
     // Add divider height as well.
     height +=
         PasswordGenerationPopupController::kPopupPasswordSectionHeight + 1;
   }
   int width = controller_->GetMinimumWidth();
-  int popup_width = width - 2 * kPopupBorderThickness;
-  height += help_label_->GetHeightForWidth(popup_width);
-  return gfx::Size(width, height + kPopupBorderThickness);
+  if (password_view_)
+    width = std::max(width, password_view_->GetMinimumSize().width());
+  height += help_label_->GetHeightForWidth(width);
+  return gfx::Size(width + 2 * kPopupBorderThickness,
+                   height + kPopupBorderThickness);
 }
 
 void PasswordGenerationPopupViewViews::Show() {
   DoShow();
 }
 
 void PasswordGenerationPopupViewViews::Hide() {
   // The controller is no longer valid after it hides us.
   controller_ = NULL;
 
@@ skipping 84 matching lines @@
   return new PasswordGenerationPopupViewViews(controller, observing_widget);
 }
 
 void PasswordGenerationPopupViewViews::GetAccessibleNodeData(
     ui::AXNodeData* node_data) {
   node_data->SetName(controller_->SuggestedText());
   node_data->role = ui::AX_ROLE_MENU_ITEM;
 }
 
 }  // namespace autofill