Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2790943003: Add ability to have active window autohide shelf (Closed)

Created:
3 years, 8 months ago by yorkelee
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Add ability to have active window autohide shelf * Actual implementation of ShellSurface.setSystemUiVisibility * Add hide_shelf_when_active_ flag to window_state which the ShelfLayoutManager uses to determine if the currently active window should autohide the shelf. * Update flag accordingly from ShellSurface BUG=705723 TEST=New unit tests, and also verify that using the implementation from Android correctly autohides the shelf for the active Android window. Add set_systemui_visibility to wayland Review-Url: https://codereview.chromium.org/2782223002 Cr-Commit-Position: refs/heads/master@{#460907} (cherry picked from commit 74669cbfbef72bde5abdecb18e9c7920cca51419) Review-Url: https://codereview.chromium.org/2790943003 . Cr-Commit-Position: refs/branch-heads/3029@{#520} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -4 lines) Patch
M ash/common/shelf/shelf_layout_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/shelf/shelf_layout_manager.cc View 4 chunks +17 lines, -2 lines 0 comments Download
M ash/common/wm/window_state.h View 2 chunks +13 lines, -0 lines 0 comments Download
M ash/common/wm/window_state.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M ash/wm/window_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M components/exo/shell_surface.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
3 years, 8 months ago (2017-03-31 21:53:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1c338b6a03a4fd3bdf05f57b4796ba6a8137f52.

Powered by Google App Engine
This is Rietveld 408576698