Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2790883004: Remove obsolete isInternaLink_() function. (Closed)

Created:
3 years, 8 months ago by danyao
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete isInternaLink_() function. The callers were removed in https://codereview.chromium.org/2669303004. BUG=614092 Review-Url: https://codereview.chromium.org/2790883004 Cr-Commit-Position: refs/heads/master@{#461582} Committed: https://chromium.googlesource.com/chromium/src/+/3423f23e28e4a31463540df78ed3a49b73c873c6

Patch Set 1 #

Patch Set 2 : y #

Patch Set 3 : Remove obsolete isInternaLink_() function. The callers were removed in https://codereview.chromium.… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M ios/web/web_state/js/resources/core.js View 1 2 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danyao
3 years, 8 months ago (2017-04-03 14:30:42 UTC) #3
Eugene But (OOO till 7-30)
Thank you for cleanup. lgtm. I reformatted CL description to follow these recommendations: https://goto.google.com/chrome-for-ios-cl-description
3 years, 8 months ago (2017-04-03 17:01:06 UTC) #5
danyao
Thank you! I'll make sure to follow the guideline next time.
3 years, 8 months ago (2017-04-03 23:37:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790883004/40001
3 years, 8 months ago (2017-04-03 23:38:42 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 23:57:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3423f23e28e4a31463540df78ed3...

Powered by Google App Engine
This is Rietveld 408576698