Removed externalRequest code from CRWWebController.

Removed externalRequest code from CRWWebController.

This code was needed for UIWebView-based app to support target="blank"
links. WKWebView natively supports opening windows by DOM and old
workaround was harmful, because it created child windows without
piping them through WKWebView callbacks which breaks sessionStorage
and cross-window scripting.

Enabled testLinkWithBlankTargetSessionStorage.
Disabled testBrowsingPreventDefaultWithLinkOpenedByJavascript because
WKWebView does not open new windows after stopPropagation() call
(crbug.com/688223).

BUG=681434, 579697
Review-Url: https://codereview.chromium.org/2669303004
Cr-Commit-Position: refs/heads/master@{#448696}
Committed: https://chromium.googlesource.com/chromium/src/+/3652d80d4a010ce23b317bcadcf0f064c07c53e1

[Eugene But (OOO till 7-30), 2017-02-03 02:30:00]

Description was changed from

==========
Removed externalRequest code from CRWWebController.

This code was needed for UIWebView-based app to support target="blank"
links. WKWebView natively supports opening windows by DOM and old
workaround was harmful, because it created child windows without
piping them through WKWebView callbacks which breaks sessionStorage
and cross-window scripting.

BUG=681434,579697
==========

to

==========
Removed externalRequest code from CRWWebController.

This code was needed for UIWebView-based app to support target="blank"
links. WKWebView natively supports opening windows by DOM and old
workaround was harmful, because it created child windows without
piping them through WKWebView callbacks which breaks sessionStorage
and cross-window scripting.

Enabled testLinkWithBlankTargetSessionStorage.
Disabled testBrowsingPreventDefaultWithLinkOpenedByJavascript because
WKWebView does not open new windows after stopPropagation() call
(crbug.com/688223).

BUG=681434,579697
==========

[Eugene But (OOO till 7-30), 2017-02-03 23:48:13]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 23:48:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 23:50:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 23:50:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2017-02-04 01:29:29]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 01:29:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 01:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 01:39:51]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-02-04 03:01:25]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org, michaeldo@chromium.org

[michaeldo, 2017-02-07 17:55:30]

lgtm

https://codereview.chromium.org/2669303004/diff/60001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (left):

https://codereview.chromium.org/2669303004/diff/60001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:2782: base::SysUTF8ToNSString(href +
web::kWindowNameSeparator + target);
It looks like web::kWindowNameSeparator can be deleted above.

[kkhorimoto, 2017-02-07 18:58:14]

lgtm.  Awesome to see all this old code finally removed!

[Eugene But (OOO till 7-30), 2017-02-07 19:14:11]

Thanks!

https://codereview.chromium.org/2669303004/diff/60001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.mm (left):

https://codereview.chromium.org/2669303004/diff/60001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.mm:2782: base::SysUTF8ToNSString(href +
web::kWindowNameSeparator + target);
On 2017/02/07 17:55:30, michaeldo wrote:
> It looks like web::kWindowNameSeparator can be deleted above.
Good catch! Compiler did not catch this because code was not in anonymous
namespace :(

[Eugene But (OOO till 7-30), 2017-02-07 19:16:20]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-02-07 19:16:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkhorimoto@chromium.org, michaeldo@chromium.org
Link to the patchset: https://codereview.chromium.org/2669303004/#ps80001
(title: "Removed kWindowNameSeparator")

[commit-bot: I haz the power, 2017-02-07 19:16:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:36:12]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486494980306640,
"parent_rev": "1a023a38bddf1b2d4e64a1f31175b72e1776713d", "commit_rev":
"3652d80d4a010ce23b317bcadcf0f064c07c53e1"}

[commit-bot: I haz the power, 2017-02-07 19:37:15]

Description was changed from

==========
Removed externalRequest code from CRWWebController.

This code was needed for UIWebView-based app to support target="blank"
links. WKWebView natively supports opening windows by DOM and old
workaround was harmful, because it created child windows without
piping them through WKWebView callbacks which breaks sessionStorage
and cross-window scripting.

Enabled testLinkWithBlankTargetSessionStorage.
Disabled testBrowsingPreventDefaultWithLinkOpenedByJavascript because
WKWebView does not open new windows after stopPropagation() call
(crbug.com/688223).

BUG=681434,579697
==========

to

==========
Removed externalRequest code from CRWWebController.

This code was needed for UIWebView-based app to support target="blank"
links. WKWebView natively supports opening windows by DOM and old
workaround was harmful, because it created child windows without
piping them through WKWebView callbacks which breaks sessionStorage
and cross-window scripting.

Enabled testLinkWithBlankTargetSessionStorage.
Disabled testBrowsingPreventDefaultWithLinkOpenedByJavascript because
WKWebView does not open new windows after stopPropagation() call
(crbug.com/688223).

BUG=681434,579697

Review-Url: https://codereview.chromium.org/2669303004
Cr-Commit-Position: refs/heads/master@{#448696}
Committed:
https://chromium.googlesource.com/chromium/src/+/3652d80d4a010ce23b317bcadcf0...
==========

[commit-bot: I haz the power, 2017-02-07 19:37:17]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3652d80d4a010ce23b317bcadcf0...