Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2790793002: Revert of Remove a superfluous optimization from ApiCompatibilityUtils (Closed)

Created:
3 years, 8 months ago by Yusuf
Modified:
3 years, 8 months ago
Reviewers:
nyquist, gone
CC:
chromium-reviews, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove a superfluous optimization from ApiCompatibilityUtils (patchset #1 id:1 of https://codereview.chromium.org/2723593002/ ) Reason for revert: crbug.com/699473 Original issue's description: > Remove a superfluous optimization from ApiCompatibilityUtils > > The optimization that is for setting the status bar color to BLACK is > causing a flash on some cold starts for Tabbed mode and Herb tabs. > > BUG=696673 > > Review-Url: https://codereview.chromium.org/2723593002 > Cr-Commit-Position: refs/heads/master@{#453433} > Committed: https://chromium.googlesource.com/chromium/src/+/9967d360b1bdd6c7317c3cbe1e1d9c2b3aea677e TBR=dfalcantara@chromium.org,nyquist@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=696673 Review-Url: https://codereview.chromium.org/2790793002 Cr-Commit-Position: refs/heads/master@{#460912} Committed: https://chromium.googlesource.com/chromium/src/+/06e3a8a95a7820bb39fbe3b64d53991649a8ee70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Yusuf
Created Revert of Remove a superfluous optimization from ApiCompatibilityUtils
3 years, 8 months ago (2017-03-30 21:35:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790793002/1
3 years, 8 months ago (2017-03-30 21:37:14 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 22:57:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/06e3a8a95a7820bb39fbe3b64d53...

Powered by Google App Engine
This is Rietveld 408576698