Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2723593002:
Remove a superfluous optimization from ApiCompatibilityUtils (Closed)
DescriptionRemove a superfluous optimization from ApiCompatibilityUtils
The optimization that is for setting the status bar color to BLACK is
causing a flash on some cold starts for Tabbed mode and Herb tabs.
BUG=696673
Review-Url: https://codereview.chromium.org/2723593002
Cr-Commit-Position: refs/heads/master@{#453433}
Committed: https://chromium.googlesource.com/chromium/src/+/9967d360b1bdd6c7317c3cbe1e1d9c2b3aea677e
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
yusufo@chromium.org changed reviewers: + dfalcantara@chromium.org
The CQ bit was checked by yusufo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yusufo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
yusufo@chromium.org changed reviewers: + nyquist@chromium.org
lgtm
The CQ bit was checked by yusufo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488243643529020, "parent_rev":
"34669ef1214c412d168021ba04bce9ac1dce4bd5", "commit_rev":
"9967d360b1bdd6c7317c3cbe1e1d9c2b3aea677e"}
Message was sent while issue was closed.
Description was changed from ========== Remove a superfluous optimization from ApiCompatibilityUtils The optimization that is for setting the status bar color to BLACK is causing a flash on some cold starts for Tabbed mode and Herb tabs. BUG=696673 ========== to ========== Remove a superfluous optimization from ApiCompatibilityUtils The optimization that is for setting the status bar color to BLACK is causing a flash on some cold starts for Tabbed mode and Herb tabs. BUG=696673 Review-Url: https://codereview.chromium.org/2723593002 Cr-Commit-Position: refs/heads/master@{#453433} Committed: https://chromium.googlesource.com/chromium/src/+/9967d360b1bdd6c7317c3cbe1e1d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9967d360b1bdd6c7317c3cbe1e1d...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2790793002/ by yusufo@chromium.org. The reason for reverting is: crbug.com/699473. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
