Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2790763002: Correct the activation of idle time spell checker on document attach (Closed)

Created:
3 years, 8 months ago by Xiaocheng
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Correct the activation of idle time spell checker on document attach There is a bug that, when a document is attached, the idle time spell checker is requested for cold mode invocation even without the IdleTimeSpellChecking flag. This patch fixes the bug. To ensure that idle time spell checker is only invoked with the flag, a DCHECK is also added to the handleEvnet() function. Related unit tests are disabled when there is no flag. BUG=700081, 517298, 706329 Review-Url: https://codereview.chromium.org/2744603004 Cr-Commit-Position: refs/heads/master@{#455942} (cherry picked from commit 624c5cfae4ce865f8ac91be865a29ff0e9fdbe34) Review-Url: https://codereview.chromium.org/2790763002 . Cr-Commit-Position: refs/branch-heads/3029@{#499} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/29a3cd8a8d8a0b9cdc72cde72d38cf7bd9a7d25b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp View 8 chunks +39 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Xiaocheng
3 years, 8 months ago (2017-03-30 21:16:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29a3cd8a8d8a0b9cdc72cde72d38cf7bd9a7d25b.

Powered by Google App Engine
This is Rietveld 408576698