Correct the activation of idle time spell checker on document attach

Correct the activation of idle time spell checker on document attach

There is a bug that, when a document is attached, the idle time spell
checker is requested for cold mode invocation even without the
IdleTimeSpellChecking flag.

This patch fixes the bug. To ensure that idle time spell checker is
only invoked with the flag, a DCHECK is also added to the handleEvnet()
function.

Related unit tests are disabled when there is no flag.

BUG=700081, 517298
Review-Url: https://codereview.chromium.org/2744603004
Cr-Commit-Position: refs/heads/master@{#455942}
Committed: https://chromium.googlesource.com/chromium/src/+/624c5cfae4ce865f8ac91be865a29ff0e9fdbe34

[Xiaocheng, 2017-03-09 23:19:40]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 23:20:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-03-10 00:42:00]

Description was changed from

==========
Correct the activation of idle time spell checker on document attach

BUG=700081
==========

to

==========
Correct the activation of idle time spell checker on document attach

There is a bug that, when a document is attached, the idle time spell
checker is requested for cold mode invocation even without the
IdleTimeSpellChecking flag.

This patch fixes the bug. To ensure that idle time spell checker is
only invoked with the flag, a DCHECK is also added to the handleEvnet()
function.

Related unit tests are disabled when there is no flag.

BUG=700081
==========

[Xiaocheng, 2017-03-10 00:42:08]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-03-10 00:42:09]

PTAL.

[Xiaocheng, 2017-03-10 00:42:38]

Description was changed from

==========
Correct the activation of idle time spell checker on document attach

There is a bug that, when a document is attached, the idle time spell
checker is requested for cold mode invocation even without the
IdleTimeSpellChecking flag.

This patch fixes the bug. To ensure that idle time spell checker is
only invoked with the flag, a DCHECK is also added to the handleEvnet()
function.

Related unit tests are disabled when there is no flag.

BUG=700081
==========

to

==========
Correct the activation of idle time spell checker on document attach

There is a bug that, when a document is attached, the idle time spell
checker is requested for cold mode invocation even without the
IdleTimeSpellChecking flag.

This patch fixes the bug. To ensure that idle time spell checker is
only invoked with the flag, a DCHECK is also added to the handleEvnet()
function.

Related unit tests are disabled when there is no flag.

BUG=700081,517298
==========

[commit-bot: I haz the power, 2017-03-10 00:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 00:43:40]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-10 01:04:16]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-03-10 01:04:17]

lgtm

[commit-bot: I haz the power, 2017-03-10 01:04:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 01:16:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489107856945610, "parent_rev":
"a3c94e4cc81caa2693ee56579e74c71e2fcadb0f", "commit_rev":
"624c5cfae4ce865f8ac91be865a29ff0e9fdbe34"}

[commit-bot: I haz the power, 2017-03-10 01:17:45]

Description was changed from

==========
Correct the activation of idle time spell checker on document attach

There is a bug that, when a document is attached, the idle time spell
checker is requested for cold mode invocation even without the
IdleTimeSpellChecking flag.

This patch fixes the bug. To ensure that idle time spell checker is
only invoked with the flag, a DCHECK is also added to the handleEvnet()
function.

Related unit tests are disabled when there is no flag.

BUG=700081,517298
==========

to

==========
Correct the activation of idle time spell checker on document attach

There is a bug that, when a document is attached, the idle time spell
checker is requested for cold mode invocation even without the
IdleTimeSpellChecking flag.

This patch fixes the bug. To ensure that idle time spell checker is
only invoked with the flag, a DCHECK is also added to the handleEvnet()
function.

Related unit tests are disabled when there is no flag.

BUG=700081,517298

Review-Url: https://codereview.chromium.org/2744603004
Cr-Commit-Position: refs/heads/master@{#455942}
Committed:
https://chromium.googlesource.com/chromium/src/+/624c5cfae4ce865f8ac91be865a2...
==========

[commit-bot: I haz the power, 2017-03-10 01:17:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/624c5cfae4ce865f8ac91be865a2...