Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2790733002: [Home] Prevent content jump when navigating from bottom sheet (Closed)

Created:
3 years, 8 months ago by mdjones
Modified:
3 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Prevent content jump when navigating from bottom sheet When the omnibox is focused the soft input mode is switched from resize to pan. When changing back in Chrome Home, the window would pan to attempt to keep the input visible (which is a moving target in Chrome Home). This change sets the input mode to do nothing for both normal and Chrome Home cases. BUG=706918 Review-Url: https://codereview.chromium.org/2790733002 Cr-Commit-Position: refs/heads/master@{#461136} Committed: https://chromium.googlesource.com/chromium/src/+/be3c0a00c44fafc9bc740764569273a688fe6c6a

Patch Set 1 #

Patch Set 2 : remove extra whitespace #

Patch Set 3 : fix test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
mdjones
ptal
3 years, 8 months ago (2017-03-30 20:10:05 UTC) #2
Ted C
lgtm
3 years, 8 months ago (2017-03-30 22:32:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790733002/20001
3 years, 8 months ago (2017-03-30 23:32:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/261836)
3 years, 8 months ago (2017-03-31 01:43:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790733002/40001
3 years, 8 months ago (2017-03-31 15:27:44 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 16:07:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/be3c0a00c44fafc9bc7407645692...

Powered by Google App Engine
This is Rietveld 408576698