Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java

Issue 2790733002: [Home] Prevent content jump when navigating from bottom sheet (Closed)
Patch Set: fix test expectation Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.omnibox; 5 package org.chromium.chrome.browser.omnibox;
6 6
7 import android.animation.ObjectAnimator; 7 import android.animation.ObjectAnimator;
8 import android.content.Context; 8 import android.content.Context;
9 import android.graphics.Canvas; 9 import android.graphics.Canvas;
10 import android.graphics.Rect; 10 import android.graphics.Rect;
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 }; 196 };
197 postDelayed(mKeyboardResizeModeTask, KEYBOARD_MODE_CHANGE_DELAY_ MS); 197 postDelayed(mKeyboardResizeModeTask, KEYBOARD_MODE_CHANGE_DELAY_ MS);
198 } 198 }
199 mUrlActionsContainer.setVisibility(GONE); 199 mUrlActionsContainer.setVisibility(GONE);
200 } else { 200 } else {
201 if (mKeyboardResizeModeTask != null) { 201 if (mKeyboardResizeModeTask != null) {
202 removeCallbacks(mKeyboardResizeModeTask); 202 removeCallbacks(mKeyboardResizeModeTask);
203 mKeyboardResizeModeTask = null; 203 mKeyboardResizeModeTask = null;
204 } 204 }
205 if (windowDelegate.getWindowSoftInputMode() 205 if (windowDelegate.getWindowSoftInputMode()
206 != WindowManager.LayoutParams.SOFT_INPUT_ADJUST_PAN) { 206 != WindowManager.LayoutParams.SOFT_INPUT_ADJUST_NOTHING) {
207 windowDelegate.setWindowSoftInputMode( 207 windowDelegate.setWindowSoftInputMode(
208 WindowManager.LayoutParams.SOFT_INPUT_ADJUST_PAN); 208 WindowManager.LayoutParams.SOFT_INPUT_ADJUST_NOTHING);
209 } 209 }
210 UiUtils.showKeyboard(mUrlBar); 210 UiUtils.showKeyboard(mUrlBar);
211 // As the position of the navigation icon has changed, ensure the su ggestions are 211 // As the position of the navigation icon has changed, ensure the su ggestions are
212 // updated to reflect the new position. 212 // updated to reflect the new position.
213 if (getSuggestionList() != null && getSuggestionList().isShown()) { 213 if (getSuggestionList() != null && getSuggestionList().isShown()) {
214 getSuggestionList().invalidateSuggestionViews(); 214 getSuggestionList().invalidateSuggestionViews();
215 } 215 }
216 } 216 }
217 setUrlFocusChangeInProgress(false); 217 setUrlFocusChangeInProgress(false);
218 218
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 protected boolean shouldAnimateIconChanges() { 301 protected boolean shouldAnimateIconChanges() {
302 return super.shouldAnimateIconChanges() || isUrlFocusChangeInProgress(); 302 return super.shouldAnimateIconChanges() || isUrlFocusChangeInProgress();
303 } 303 }
304 304
305 @Override 305 @Override
306 public void setLayoutDirection(int layoutDirection) { 306 public void setLayoutDirection(int layoutDirection) {
307 super.setLayoutDirection(layoutDirection); 307 super.setLayoutDirection(layoutDirection);
308 updateIncognitoBadgePadding(); 308 updateIncognitoBadgePadding();
309 } 309 }
310 } 310 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698