Function to count dialog box creations.

chrome/browser/ui/views/dialog_uma/dialog_uma.h

Index: chrome/browser/ui/views/dialog_uma/dialog_uma.h
diff --git a/chrome/browser/ui/views/dialog_uma/dialog_uma.h b/chrome/browser/ui/views/dialog_uma/dialog_uma.h
new file mode 100644
index 0000000000000000000000000000000000000000..c03030d84403273577bd8cf1efad27e77f9479d6
--- /dev/null
+++ b/chrome/browser/ui/views/dialog_uma/dialog_uma.h
@@ -0,0 +1,19 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_
+#define CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_
+
+// Values used in the Dialog.Creation UMA metric. Each value represents a
+// different type of dialog box.
+// These values are written to logs. New enum values can be added, but existing
+// enums must never be renumbered or deleted and reused.
+enum DialogBoxIdentifier {

[tapted, 2017/04/03 09:31:30]

enum class DialogIdentifier

(currently this pollutes the global namespace with the identifier `UNKNOWN`)

(also I'd drop the "box" part of the enum type)

[pdyson, 2017/04/04 00:54:43]

Done and Done.

+  UNKNOWN = 0,
+  TRANSLATE = 1,
+};
+
+void ReportDialogCreation(DialogBoxIdentifier identifier);

[tapted, 2017/04/03 09:31:30]

nit: needs a comment

also other UMA stuff (e.g. touch_uma) tends towards "Record" rather than
"Report"

[pdyson, 2017/04/04 00:54:43]

Translate used Report, but I see Record elsewhere. Changed to Record. Added
comment.

+
+#endif  // CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_