chrome/browser/ui/views/dialog_uma/dialog_uma.h - Issue 2790723004: Function to count dialog box creations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/dialog_uma/dialog_uma.h

Issue 2790723004: Function to count dialog box creations. (Closed)

Patch Set: Use function instead of class for logging. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_

	6 #define CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_

	7

	8 // Values used in the Dialog.Creation UMA metric. Each value represents a

	9 // different type of dialog box.

	10 // These values are written to logs. New enum values can be added, but existing

	11 // enums must never be renumbered or deleted and reused.

	12 enum DialogBoxIdentifier {
	tapted 2017/04/03 09:31:30 enum class DialogIdentifier (currently this pollu enum class DialogIdentifier (currently this pollutes the global namespace with the identifier `UNKNOWN`) (also I'd drop the "box" part of the enum type) pdyson 2017/04/04 00:54:43 Done and Done. Show quoted text On 2017/04/03 at 09:31:30, tapted wrote: > enum class DialogIdentifier > > (currently this pollutes the global namespace with the identifier `UNKNOWN`) > > (also I'd drop the "box" part of the enum type) Done and Done.
	13 UNKNOWN = 0,

	14 TRANSLATE = 1,

	15 };

	16

	17 void ReportDialogCreation(DialogBoxIdentifier identifier);
	tapted 2017/04/03 09:31:30 nit: needs a comment also other UMA stuff (e.g. t nit: needs a comment also other UMA stuff (e.g. touch_uma) tends towards "Record" rather than "Report" pdyson 2017/04/04 00:54:43 Translate used Report, but I see Record elsewhere. Show quoted text On 2017/04/03 at 09:31:30, tapted wrote: > nit: needs a comment > > also other UMA stuff (e.g. touch_uma) tends towards "Record" rather than "Report" Translate used Report, but I see Record elsewhere. Changed to Record. Added comment.
	18

	19 #endif // CHROME_BROWSER_UI_VIEWS_DIALOG_UMA_DIALOG_UMA_H_

OLD	NEW

« chrome/browser/ui/BUILD.gn ('K') | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/views/dialog_uma/dialog_uma.cc » ('j') | chrome/browser/ui/views/dialog_uma/dialog_uma.cc » ('J')