Function to count dialog box creations.

chrome/browser/ui/views/dialog_uma/dialog_uma.cc

Index: chrome/browser/ui/views/dialog_uma/dialog_uma.cc
diff --git a/chrome/browser/ui/views/dialog_uma/dialog_uma.cc b/chrome/browser/ui/views/dialog_uma/dialog_uma.cc
new file mode 100644
index 0000000000000000000000000000000000000000..757594052802a474a7a6bd13196da4f830f2148b
--- /dev/null
+++ b/chrome/browser/ui/views/dialog_uma/dialog_uma.cc
@@ -0,0 +1,11 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/dialog_uma/dialog_uma.h"
+
+#include "base/metrics/histogram_macros.h"
+
+void ReportDialogCreation(DialogBoxIdentifier identifier) {
+  UMA_HISTOGRAM_SPARSE_SLOWLY("Dialog.Creation", identifier);

[tapted, 2017/04/03 09:31:30]

I'm not really a UMA expert, but I think

UMA_HISTOGRAM_ENUMERATION("Dialog.Creation", static_cast<int>(identifier),
static_cast<int>(DialogBoxIdentifier::MAX_VALUE)); 

is the best way to log this

[jwd, 2017/04/03 23:02:04]

Yeah, I'd agree. If we move towards having non-contiguous enum values with big
gaps between values, it may make sense to move to the sparse though. We can
always make the switch to sparse later.

[pdyson, 2017/04/04 00:54:43]

Oh, yes. An earlier version of this had sparse enums, but now they are
contiguous. Changed.

 

+}