chrome/browser/ui/views/dialog_uma/dialog_uma.cc - Issue 2790723004: Function to count dialog box creations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/dialog_uma/dialog_uma.cc

Issue 2790723004: Function to count dialog box creations. (Closed)

Patch Set: Use function instead of class for logging. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/dialog_uma/dialog_uma.h ('K') | « chrome/browser/ui/views/dialog_uma/dialog_uma.h ('k') | chrome/browser/ui/views/translate/translate_bubble_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/views/dialog_uma/dialog_uma.h"

	6

	7 #include "base/metrics/histogram_macros.h"

	8

	9 void ReportDialogCreation(DialogBoxIdentifier identifier) {

	10 UMA_HISTOGRAM_SPARSE_SLOWLY("Dialog.Creation", identifier);
	tapted 2017/04/03 09:31:30 I'm not really a UMA expert, but I think UMA_HIST I'm not really a UMA expert, but I think UMA_HISTOGRAM_ENUMERATION("Dialog.Creation", static_cast<int>(identifier), static_cast<int>(DialogBoxIdentifier::MAX_VALUE)); is the best way to log this jwd 2017/04/03 23:02:04 Yeah, I'd agree. If we move towards having non-con Show quoted text On 2017/04/03 09:31:30, tapted wrote: > I'm not really a UMA expert, but I think > > UMA_HISTOGRAM_ENUMERATION("Dialog.Creation", static_cast<int>(identifier), > static_cast<int>(DialogBoxIdentifier::MAX_VALUE)); > > is the best way to log this Yeah, I'd agree. If we move towards having non-contiguous enum values with big gaps between values, it may make sense to move to the sparse though. We can always make the switch to sparse later. pdyson 2017/04/04 00:54:43 Oh, yes. An earlier version of this had sparse enu Show quoted text On 2017/04/03 at 23:02:04, jwd wrote: > On 2017/04/03 09:31:30, tapted wrote: > > I'm not really a UMA expert, but I think > > > > UMA_HISTOGRAM_ENUMERATION("Dialog.Creation", static_cast<int>(identifier), > > static_cast<int>(DialogBoxIdentifier::MAX_VALUE)); > > > > is the best way to log this > > Yeah, I'd agree. If we move towards having non-contiguous enum values with big gaps between values, it may make sense to move to the sparse though. We can always make the switch to sparse later. Oh, yes. An earlier version of this had sparse enums, but now they are contiguous. Changed.
	11 }

OLD	NEW