[WIP] Move DocumentMarker accessors into subclasses

Move DocumentMarker accessors into subclasses

Continuing the refactor in https://codereview.chromium.org/2780313002.

This CL moves the accessor methods that are specific to subclasses of
DocumentMarker into those subclasses, requiring callers to cast if they're
holding a DocumentMarker[*/&].

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

[rlanday, 2017-03-31 18:41:57]

Description was changed from

==========
Move DocumentMarker accessors into subclasses

Continuing the refactor in https://codereview.chromium.org/2780313002.

This CL moves the accessor methods that are specific to subclasses of
DocumentMarker into those subclasses, requiring callers to cast if they're
holding a DocumentMarker[*/&].

BUG=
==========

to

==========
Move DocumentMarker accessors into subclasses

Continuing the refactor in https://codereview.chromium.org/2780313002.

This CL moves the accessor methods that are specific to subclasses of
DocumentMarker into those subclasses, requiring callers to cast if they're
holding a DocumentMarker[*/&].

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rlanday, 2017-03-31 18:42:23]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org

[Xiaocheng, 2017-03-31 20:07:31]

https://codereview.chromium.org/2790703004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h
(right):

https://codereview.chromium.org/2790703004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h:19:
CompositionMarker* at(size_t index) final;
Virtual |at()| should be in the previous patch.

[rlanday, 2017-04-03 18:00:45]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-04-03 18:00:50]

On 2017/03/31 at 20:07:31, xiaochengh wrote:
>
https://codereview.chromium.org/2790703004/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h
(right):
> 
>
https://codereview.chromium.org/2790703004/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h:19:
CompositionMarker* at(size_t index) final;
> Virtual |at()| should be in the previous patch.

Updated

[commit-bot: I haz the power, 2017-04-03 18:01:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 18:07:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 18:07:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Xiaocheng, 2017-04-03 18:22:07]

On 2017/04/03 at 18:00:50, rlanday wrote:
> On 2017/03/31 at 20:07:31, xiaochengh wrote:
> >
https://codereview.chromium.org/2790703004/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h
(right):
> > 
> >
https://codereview.chromium.org/2790703004/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h:19:
CompositionMarker* at(size_t index) final;
> > Virtual |at()| should be in the previous patch.
> 
> Updated

Patch failure...

[rlanday, 2017-04-03 18:44:04]

On 2017/04/03 at 18:22:08, xiaochengh wrote:
> On 2017/04/03 at 18:00:50, rlanday wrote:
> > On 2017/03/31 at 20:07:31, xiaochengh wrote:
> > >
https://codereview.chromium.org/2790703004/diff/1/third_party/WebKit/Source/c...
> > > File
third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h (right):
> > > 
> > >
https://codereview.chromium.org/2790703004/diff/1/third_party/WebKit/Source/c...
> > > third_party/WebKit/Source/core/editing/markers/CompositionMarkerList.h:19:
CompositionMarker* at(size_t index) final;
> > > Virtual |at()| should be in the previous patch.
> > 
> > Updated
> 
> Patch failure...

I think the problem is that the "Refactor DocumentMarkerController" patch
(https://codereview.chromium.org/2723663002/) deletes RenderedDocumentMarker.h,
which is updated in the CL that adds DocumentMarker::clone()
(https://codereview.chromium.org/2781623010), creating a conflict in the eyes of
the patch system. Once we land the clone() CL, these trybots should start
patching properly.

[Xiaocheng, 2017-04-03 18:52:04]

OK, lgtm

[rlanday, 2017-04-03 18:55:07]

Description was changed from

==========
Move DocumentMarker accessors into subclasses

Continuing the refactor in https://codereview.chromium.org/2780313002.

This CL moves the accessor methods that are specific to subclasses of
DocumentMarker into those subclasses, requiring callers to cast if they're
holding a DocumentMarker[*/&].

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move DocumentMarker accessors into subclasses

Continuing the refactor in https://codereview.chromium.org/2780313002.

This CL moves the accessor methods that are specific to subclasses of
DocumentMarker into those subclasses, requiring callers to cast if they're
holding a DocumentMarker[*/&].

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========