third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp - Issue 2790703004: [WIP] Move DocumentMarker accessors into subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2790703004: [WIP] Move DocumentMarker accessors into subclasses (Closed)

Patch Set: Move CompositionMarkerList::at() into previous CL Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp ('k') | third_party/WebKit/Source/core/editing/markers/SpellCheckMarker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

index 4d74ac886e419d8dddf290df278481316084ceac..9c58d8f68325e7940349f484924c3df399a00396 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

@@ -439,7 +439,10 @@ static String showMarkerHelper(const DocumentMarkerVector& markers) {

builder.append(":");

builder.appendNumber(marker->endOffset());

builder.append("](");

- builder.appendNumber(marker->activeMatch());

+ if (marker->type() == DocumentMarker::TextMatch)

+ builder.appendNumber(toTextMatchMarker(marker)->activeMatch());

+ else

+ builder.appendNumber(0);

builder.append(")");

}