third_party/WebKit/Source/core/editing/markers/DocumentMarker.h - Issue 2790703004: [WIP] Move DocumentMarker accessors into subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

Issue 2790703004: [WIP] Move DocumentMarker accessors into subclasses (Closed)

Patch Set: Move CompositionMarkerList::at() into previous CL Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

index d152b37f24a556615246f5521145ceefb319513c..6d0d52bcde6425e870729c6c6a0fc70ea5461b8b 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

@@ -142,14 +142,6 @@ class CORE_EXPORT DocumentMarker

unsigned startOffset() const { return m_startOffset; }

unsigned endOffset() const { return m_endOffset; }

- // TODO(rlanday): move these accessors into the derived classes (will require

- // adding casts in a bunch of callers)

- virtual const String& description() const;

- virtual bool activeMatch() const;

- virtual Color underlineColor() const;

- virtual bool thick() const;

- virtual Color backgroundColor() const;

struct MarkerOffsets {

unsigned startOffset;

unsigned endOffset;