Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2790633002: predictors: Remove unknown fields from PrecacheManifest before store it. (Closed)

Created:
3 years, 8 months ago by alexilin
Modified:
3 years, 8 months ago
Reviewers:
Benoit L
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Remove unknown fields from PrecacheManifest before store it. PrecacheManifest comes to ResourcePrefetchPredictor from an external source that could have a different protobuf definition. The definition could contain fields that are unknown for the current version of Chromium. During deserialization, unknown fields are not discarded but stored in unknown_fields. The database has to be wiped out after update of the .proto file so there is no need to store unknown fields. BUG=699115 Review-Url: https://codereview.chromium.org/2790633002 Cr-Commit-Position: refs/heads/master@{#461668} Committed: https://chromium.googlesource.com/chromium/src/+/0559ee094eaf06da395d78b81cae19352ac68f9c

Patch Set 1 #

Patch Set 2 : Move implementation into .cc file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
alexilin
Hi lizeb! Review my change, please.
3 years, 8 months ago (2017-03-30 14:25:55 UTC) #2
Benoit L
On 2017/03/30 14:25:55, alexilin wrote: > Hi lizeb! Review my change, please. lgtm, thanks.
3 years, 8 months ago (2017-03-31 08:32:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790633002/20001
3 years, 8 months ago (2017-04-04 08:52:21 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 09:38:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0559ee094eaf06da395d78b81cae...

Powered by Google App Engine
This is Rietveld 408576698