Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: chrome/browser/predictors/resource_prefetch_predictor.cc

Issue 2790633002: predictors: Remove unknown fields from PrecacheManifest before store it. (Closed)
Patch Set: Move implementation into .cc file. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/predictors/resource_prefetch_predictor_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/predictors/resource_prefetch_predictor.h" 5 #include "chrome/browser/predictors/resource_prefetch_predictor.h"
6 6
7 #include <map> 7 #include <map>
8 #include <set> 8 #include <set>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 precision_percentage); 214 precision_percentage);
215 UMA_HISTOGRAM_PERCENTAGE(internal::kResourcePrefetchPredictorRecallHistogram, 215 UMA_HISTOGRAM_PERCENTAGE(internal::kResourcePrefetchPredictorRecallHistogram,
216 recall_percentage); 216 recall_percentage);
217 UMA_HISTOGRAM_COUNTS_100(internal::kResourcePrefetchPredictorCountHistogram, 217 UMA_HISTOGRAM_COUNTS_100(internal::kResourcePrefetchPredictorCountHistogram,
218 predicted_urls.size()); 218 predicted_urls.size());
219 UMA_HISTOGRAM_ENUMERATION( 219 UMA_HISTOGRAM_ENUMERATION(
220 internal::kResourcePrefetchPredictorRedirectStatusHistogram, 220 internal::kResourcePrefetchPredictorRedirectStatusHistogram,
221 static_cast<int>(redirect_status), static_cast<int>(RedirectStatus::MAX)); 221 static_cast<int>(redirect_status), static_cast<int>(RedirectStatus::MAX));
222 } 222 }
223 223
224 void RemoveUnknownFieldsFromPrecacheManifest(
225 precache::PrecacheManifest* manifest) {
226 manifest->mutable_unknown_fields()->clear();
227 for (auto& resource : *manifest->mutable_resource())
228 resource.mutable_unknown_fields()->clear();
229 if (manifest->has_experiments()) {
230 manifest->mutable_experiments()->mutable_unknown_fields()->clear();
231 for (auto& kv : *manifest->mutable_experiments()
232 ->mutable_resources_by_experiment_group()) {
233 kv.second.mutable_unknown_fields()->clear();
234 }
235 }
236 if (manifest->has_id())
237 manifest->mutable_id()->mutable_unknown_fields()->clear();
238 }
239
224 } // namespace 240 } // namespace
225 241
226 //////////////////////////////////////////////////////////////////////////////// 242 ////////////////////////////////////////////////////////////////////////////////
227 // ResourcePrefetchPredictor static functions. 243 // ResourcePrefetchPredictor static functions.
228 244
229 // static 245 // static
230 bool ResourcePrefetchPredictor::ShouldRecordRequest( 246 bool ResourcePrefetchPredictor::ShouldRecordRequest(
231 net::URLRequest* request, 247 net::URLRequest* request,
232 content::ResourceType resource_type) { 248 content::ResourceType resource_type) {
233 const content::ResourceRequestInfo* request_info = 249 const content::ResourceRequestInfo* request_info =
(...skipping 1225 matching lines...) Expand 10 before | Expand all | Expand 10 after
1459 auto cache_entry = manifest_table_cache_->find(host); 1475 auto cache_entry = manifest_table_cache_->find(host);
1460 if (cache_entry == manifest_table_cache_->end()) { 1476 if (cache_entry == manifest_table_cache_->end()) {
1461 if (manifest_table_cache_->size() >= config_.max_hosts_to_track) 1477 if (manifest_table_cache_->size() >= config_.max_hosts_to_track)
1462 RemoveOldestEntryInManifestDataMap(manifest_table_cache_.get()); 1478 RemoveOldestEntryInManifestDataMap(manifest_table_cache_.get());
1463 cache_entry = 1479 cache_entry =
1464 manifest_table_cache_->insert(std::make_pair(host, manifest)).first; 1480 manifest_table_cache_->insert(std::make_pair(host, manifest)).first;
1465 } else { 1481 } else {
1466 cache_entry->second = manifest; 1482 cache_entry->second = manifest;
1467 } 1483 }
1468 1484
1485 RemoveUnknownFieldsFromPrecacheManifest(&cache_entry->second);
1486
1469 BrowserThread::PostTask( 1487 BrowserThread::PostTask(
1470 BrowserThread::DB, FROM_HERE, 1488 BrowserThread::DB, FROM_HERE,
1471 base::Bind(&ResourcePrefetchPredictorTables::UpdateManifestData, tables_, 1489 base::Bind(&ResourcePrefetchPredictorTables::UpdateManifestData, tables_,
1472 host, cache_entry->second)); 1490 host, cache_entry->second));
1473 } 1491 }
1474 1492
1475 void ResourcePrefetchPredictor::ConnectToHistoryService() { 1493 void ResourcePrefetchPredictor::ConnectToHistoryService() {
1476 // Register for HistoryServiceLoading if it is not ready. 1494 // Register for HistoryServiceLoading if it is not ready.
1477 history::HistoryService* history_service = 1495 history::HistoryService* history_service =
1478 HistoryServiceFactory::GetForProfile(profile_, 1496 HistoryServiceFactory::GetForProfile(profile_,
(...skipping 14 matching lines...) Expand all
1493 TestObserver::~TestObserver() { 1511 TestObserver::~TestObserver() {
1494 predictor_->SetObserverForTesting(nullptr); 1512 predictor_->SetObserverForTesting(nullptr);
1495 } 1513 }
1496 1514
1497 TestObserver::TestObserver(ResourcePrefetchPredictor* predictor) 1515 TestObserver::TestObserver(ResourcePrefetchPredictor* predictor)
1498 : predictor_(predictor) { 1516 : predictor_(predictor) {
1499 predictor_->SetObserverForTesting(this); 1517 predictor_->SetObserverForTesting(this);
1500 } 1518 }
1501 1519
1502 } // namespace predictors 1520 } // namespace predictors
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/predictors/resource_prefetch_predictor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698