Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2790493007: test: promote --train to its own subcommand (Closed)

Created:
3 years, 8 months ago by Paweł Hajdan Jr.
Modified:
3 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

test: promote --train to its own subcommand It turns out it's more discoverable that way, and the switch was confusing for people. BUG=chromium:699120 Review-Url: https://codereview.chromium.org/2790493007 Committed: https://github.com/luci/recipes-py/commit/e02889f17c4ac35b7fb99915c5e05a9dde1347c0

Patch Set 1 #

Total comments: 2

Patch Set 2 : deprectaed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M recipe_engine/autoroll.py View 4 chunks +4 lines, -4 lines 0 comments Download
M recipe_engine/test.py View 1 1 chunk +20 lines, -1 line 0 comments Download
M unittests/repo_test_util.py View 1 chunk +1 line, -1 line 0 comments Download
M unittests/test_test.py View 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Paweł Hajdan Jr.
3 years, 8 months ago (2017-03-31 17:48:30 UTC) #7
iannucci
lgtm https://codereview.chromium.org/2790493007/diff/1/recipe_engine/test.py File recipe_engine/test.py (right): https://codereview.chromium.org/2790493007/diff/1/recipe_engine/test.py#newcode738 recipe_engine/test.py:738: help='re-generate recipe expectations') let's add a deprecation text ...
3 years, 8 months ago (2017-03-31 17:50:09 UTC) #8
Paweł Hajdan Jr.
https://codereview.chromium.org/2790493007/diff/1/recipe_engine/test.py File recipe_engine/test.py (right): https://codereview.chromium.org/2790493007/diff/1/recipe_engine/test.py#newcode738 recipe_engine/test.py:738: help='re-generate recipe expectations') On 2017/03/31 17:50:09, iannucci wrote: > ...
3 years, 8 months ago (2017-03-31 17:51:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790493007/20001
3 years, 8 months ago (2017-03-31 17:51:51 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 17:55:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/e02889f17c4ac35b7fb99915c5e05a9dde1...

Powered by Google App Engine
This is Rietveld 408576698