test: promote --train to its own subcommand

recipe_engine/test.py

 # Copyright 2017 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 from __future__ import print_function
 
 import argparse
 import bdb
 import cStringIO
 import contextlib
@@ skipping 714 matching lines @@
   run_p.add_argument(
       '--json', metavar='FILE', type=argparse.FileType('w'),
       help='path to JSON output file')
   run_p.add_argument(
       '--filter', action='append',
       help='glob filter for the tests to run; '
            'can be specified multiple times; '
            'the globs have the form of '
            '`<recipe_name_glob>[.<test_name_glob>]`. If `.<test_name_glob>` '
            'is omitted, it is implied to be `.*`, i.e. all tests.)')
+  # TODO(phajdan.jr): remove --train the switch in favor of train subcommand.
   run_p.add_argument(
       '--train', action='store_true',
       help='re-generate recipe expectations')

[iannucci, 2017/03/31 17:50:09]

let's add a deprecation text in the help too.

[Paweł Hajdan Jr., 2017/03/31 17:51:44]

Done.

 
+  train_p = subp.add_parser('train', description='Re-train recipe expectations')
+  train_p.set_defaults(func=lambda opts: run_run(
+      opts.filter, jobs=opts.jobs, json_file=opts.json, train=True))
+  train_p.add_argument(
+      '--jobs', metavar='N', type=int,
+      default=multiprocessing.cpu_count(),
+      help='run N jobs in parallel (default %(default)s)')
+  train_p.add_argument(
+      '--json', metavar='FILE', type=argparse.FileType('w'),
+      help='path to JSON output file')
+  train_p.add_argument(
+      '--filter', action='append',
+      help='glob filter for the tests to run; '
+           'can be specified multiple times; '
+           'the globs have the form of '
+           '`<recipe_name_glob>[.<test_name_glob>]`. If `.<test_name_glob>` '
+           'is omitted, it is implied to be `.*`, i.e. all tests.)')
+
   debug_p = subp.add_parser(
       'debug', description='Run the tests under debugger (pdb)')
   debug_p.set_defaults(func=lambda opts: run_run(
       opts.filter, debug=True))
   debug_p.add_argument(
       '--filter', action='append',
       help='glob filter for the tests to run; '
            'can be specified multiple times; '
            'the globs have the form of '
            '`<recipe_name_glob>[.<test_name_glob>]`. If `.<test_name_glob>` '
@@ skipping 23 matching lines @@
   Returns:
     Exit code
   """
   global _UNIVERSE_VIEW
   _UNIVERSE_VIEW = universe_view
   global _ENGINE_FLAGS
   _ENGINE_FLAGS = engine_flags
 
   args = parse_args(raw_args)
   return args.func(args)