Chromium Code Reviews Chromium Code Reviews
Issue
2790473005:
Reland of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (Closed)
DescriptionReland of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #1 id:1 of https://codereview.chromium.org/2754973002/ )
Reason for revert:
pnacl should no longer complain about this switch.
Original issue's description:
> Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #1 id:1 of https://codereview.chromium.org/2756713002/ )
>
> Reason for revert:
> Still breaks pnacl-ld on Windows: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Win%2F16241%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
> pnacl-ld: "--build-id=sha1" affects translation. To allow, specify --pnacl-allow-native
>
>
> Original issue's description:
> > Reland of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #1 id:1 of https://codereview.chromium.org/2732023004/ )
> >
> > Reason for revert:
> > With https://bugs.chromium.org/p/nativeclient/issues/detail?id=4391#c1 fixed, this might now work.
> >
> > Original issue's description:
> > > Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #2 id:20001 of https://codereview.chromium.org/2732293002/ )
> > >
> > > Reason for revert:
> > > https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/30394/steps/compile/logs/stdio
> > >
> > > pnacl-ld: Unrecognized option: --build-id=sha1
> > >
> > > gn args:
> > > goma_dir = "/b/c/goma_client"
> > > is_chrome_branded = true
> > > is_debug = false
> > > is_official_build = true
> > > target_os = "chromeos"
> > > use_goma = true
> > >
> > > Original issue's description:
> > > > build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON
> > > >
> > > > BUG=622775
> > > >
> > > > Review-Url: https://codereview.chromium.org/2732293002
> > > > Cr-Commit-Position: refs/heads/master@{#455154}
> > > > Committed: https://chromium.googlesource.com/chromium/src/+/4e5c4a1545902ab817b8d758c8b3ec4380552b5d
> > >
> > > TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=622775
> > >
> > > Review-Url: https://codereview.chromium.org/2732023004
> > > Cr-Commit-Position: refs/heads/master@{#455172}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/e806d46df51009e8c254727b374873bc4379b1fb
> >
> > TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=622775
> >
> > Review-Url: https://codereview.chromium.org/2756713002
> > Cr-Commit-Position: refs/heads/master@{#457493}
> > Committed: https://chromium.googlesource.com/chromium/src/+/c3cb7d84db9a7d99ae917f32c1acca0f44ca3b22
>
> TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=622775
>
> Review-Url: https://codereview.chromium.org/2754973002
> Cr-Commit-Position: refs/heads/master@{#457523}
> Committed: https://chromium.googlesource.com/chromium/src/+/c9650610e0df4aa3d24cdb52f1139c17cdfe530b
TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=622775
Review-Url: https://codereview.chromium.org/2790473005 .
Cr-Commit-Position: refs/heads/master@{#461188}
Committed: https://chromium.googlesource.com/chromium/src/+/1bafcfdfcc6867b9be120e54c73b0ea526cd886e
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
|
||||||||||||||||||||||||||||
