Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2732023004: Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
hans, Torne, Roland McGrath
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON (patchset #2 id:20001 of https://codereview.chromium.org/2732293002/ ) Reason for revert: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/30394/steps/compile/logs/stdio pnacl-ld: Unrecognized option: --build-id=sha1 gn args: goma_dir = "/b/c/goma_client" is_chrome_branded = true is_debug = false is_official_build = true target_os = "chromeos" use_goma = true Original issue's description: > build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON > > BUG=622775 > > Review-Url: https://codereview.chromium.org/2732293002 > Cr-Commit-Position: refs/heads/master@{#455154} > Committed: https://chromium.googlesource.com/chromium/src/+/4e5c4a1545902ab817b8d758c8b3ec4380552b5d TBR=hans@chromium.org,torne@chromium.org,mcgrathr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622775 Review-Url: https://codereview.chromium.org/2732023004 Cr-Commit-Position: refs/heads/master@{#455172} Committed: https://chromium.googlesource.com/chromium/src/+/e806d46df51009e8c254727b374873bc4379b1fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M build/config/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
Created Revert of build: Prepare for building clang without ENABLE_LINKER_BUILD_ID=ON
3 years, 9 months ago (2017-03-07 19:26:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732023004/1
3 years, 9 months ago (2017-03-07 19:27:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e806d46df51009e8c254727b374873bc4379b1fb
3 years, 9 months ago (2017-03-07 19:28:52 UTC) #6
Nico
3 years, 9 months ago (2017-03-16 16:37:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2756713002/ by thakis@chromium.org.

The reason for reverting is: With
https://bugs.chromium.org/p/nativeclient/issues/detail?id=4391#c1 fixed, this
might now work..

Powered by Google App Engine
This is Rietveld 408576698