Fix WTF::makeUnique for arrays

Fix WTF::makeUnique for arrays

base::makeUnique and std::make_unique support allocating arrays with the
syntax base::makeUnique<char[]>(20).

WTF::makeUnique calls WTF::IsGarbageCollectedType<T> to make sure it
isn't attempting to makeUnique on a GC type. But that requires T be a
complete type, and char[] isn't.

R=esprehn@chromium.org
BUG=706715
Review-Url: https://codereview.chromium.org/2790463002
Cr-Commit-Position: refs/heads/master@{#460850}
Committed: https://chromium.googlesource.com/chromium/src/+/54702b16778aa3319f93a32d3ffdc4aef1c9a831

[cblume, 2017-03-30 06:49:05]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 06:49:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cblume, 2017-03-30 06:52:02]

PTAL

[Yuta Kitamura, 2017-03-30 07:00:32]

yutak@chromium.org changed reviewers:
+ yutak@chromium.org

[Yuta Kitamura, 2017-03-30 07:00:33]

LGTM w/ nits

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/BUILD.gn:1862: "wtf/PtrUtilTest.cpp",
This is strange but understandable according to the current situation of
WTF code move. wtf_unittests and all the tests currently exist in
wtf/, not here, but I'll move the test target to here very soon, and
I can move this test to the correct target then.

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/wtf/PtrUtilTest.cpp (right):

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/wtf/PtrUtilTest.cpp:5: #include
"wtf/PtrUtil.h"
Use "platform/wtf/PtrUtil.h"

[cblume, 2017-03-30 07:11:02]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 07:11:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cblume, 2017-03-30 07:11:22]

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/BUILD.gn:1862: "wtf/PtrUtilTest.cpp",
On 2017/03/30 07:00:33, Yuta Kitamura wrote:
> This is strange but understandable according to the current situation of
> WTF code move. wtf_unittests and all the tests currently exist in
> wtf/, not here, but I'll move the test target to here very soon, and
> I can move this test to the correct target then.

Right, the move is exactly why I placed it here.
The doc said it should go in blink_platform_unittests with a note for
alternatives.

I'm happy to place it where ever you prefer.
I just thought it would be annoying to pile more tests onto the wrong target.
But if that isn't the case, let's move it. :)

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/wtf/PtrUtilTest.cpp (right):

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/wtf/PtrUtilTest.cpp:5: #include
"wtf/PtrUtil.h"
On 2017/03/30 07:00:33, Yuta Kitamura wrote:
> Use "platform/wtf/PtrUtil.h"

Done.

[Yuta Kitamura, 2017-03-30 08:45:49]

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2790463002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/BUILD.gn:1862: "wtf/PtrUtilTest.cpp",
NP, just land this and I'll settle the things :)

[commit-bot: I haz the power, 2017-03-30 09:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 09:41:20]

Dry run: This issue passed the CQ dry run.

[cblume, 2017-03-30 18:45:47]

esprehn@, I think I still need your approval for platform/BUILD.gn

[esprehn, 2017-03-30 19:04:04]

lgtm, we should get a BUILD file into platform/wtf so the OWNERS inside there
can approve things.

[cblume, 2017-03-30 19:19:47]

The CQ bit was checked by cblume@chromium.org

[cblume, 2017-03-30 19:19:47]

The patchset sent to the CQ was uploaded after l-g-t-m from yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2790463002/#ps20001
(title: "Updating include path")

[commit-bot: I haz the power, 2017-03-30 19:20:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 19:33:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490901587230320,
"parent_rev": "0eddb7dc53c069e739d0dceb3bc7156a57882dac", "commit_rev":
"54702b16778aa3319f93a32d3ffdc4aef1c9a831"}

[commit-bot: I haz the power, 2017-03-30 19:39:24]

Description was changed from

==========
Fix WTF::makeUnique for arrays

base::makeUnique and std::make_unique support allocating arrays with the
syntax base::makeUnique<char[]>(20).

WTF::makeUnique calls WTF::IsGarbageCollectedType<T> to make sure it
isn't attempting to makeUnique on a GC type. But that requires T be a
complete type, and char[] isn't.

R=esprehn@chromium.org
BUG=706715
==========

to

==========
Fix WTF::makeUnique for arrays

base::makeUnique and std::make_unique support allocating arrays with the
syntax base::makeUnique<char[]>(20).

WTF::makeUnique calls WTF::IsGarbageCollectedType<T> to make sure it
isn't attempting to makeUnique on a GC type. But that requires T be a
complete type, and char[] isn't.

R=esprehn@chromium.org
BUG=706715

Review-Url: https://codereview.chromium.org/2790463002
Cr-Commit-Position: refs/heads/master@{#460850}
Committed:
https://chromium.googlesource.com/chromium/src/+/54702b16778aa3319f93a32d3ffd...
==========

[commit-bot: I haz the power, 2017-03-30 19:39:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54702b16778aa3319f93a32d3ffd...