Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2787223002: Add more WTF::PtrUtil unit tests (Closed)

Created:
3 years, 8 months ago by cblume
Modified:
3 years, 8 months ago
Reviewers:
esprehn, Yuta Kitamura
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more WTF::PtrUtil unit tests I recently added a unit test to cover a case that was failing. But the other cases were not covered either. Write some tests to cover everything in WTF::PtrUtil. R=yutak@chromium.org BUG=707089 Review-Url: https://codereview.chromium.org/2787223002 Cr-Commit-Position: refs/heads/master@{#461392} Committed: https://chromium.googlesource.com/chromium/src/+/9a254ff19df85b20fdc6b6431f9e8cf7f6912cc8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M third_party/WebKit/Source/platform/wtf/PtrUtilTest.cpp View 1 chunk +25 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
cblume
PTAL
3 years, 8 months ago (2017-03-31 19:53:05 UTC) #5
cblume
+Elliot
3 years, 8 months ago (2017-03-31 19:53:58 UTC) #7
Yuta Kitamura
lgtm
3 years, 8 months ago (2017-04-03 07:59:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787223002/1
3 years, 8 months ago (2017-04-03 08:23:42 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 09:24:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a254ff19df85b20fdc6b6431f9e...

Powered by Google App Engine
This is Rietveld 408576698