Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2790453002: Fix case error in install-build-deps.sh (Closed)

Created:
3 years, 8 months ago by kjellander_chromium
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix case error in install-build-deps.sh It appears the "*" path in the case statement is never matched due to the double-quotes (tested with bash 4.3.11 on Trusty 14.04). Removing the quoting aligns with other case statements in the script, and solves the problem. This bug made https://codereview.chromium.org/2650823010 not have any effect, which was discovered when deploying ARM 64 bots for WebRTC. BUG=684356, webrtc:7024 Review-Url: https://codereview.chromium.org/2790453002 Cr-Commit-Position: refs/heads/master@{#460733} Committed: https://chromium.googlesource.com/chromium/src/+/95504aea9818ec4e593358d0373f9c41531a3b67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/install-build-deps.sh View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kjellander_chromium
3 years, 8 months ago (2017-03-30 06:55:09 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-03-30 11:54:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790453002/1
3 years, 8 months ago (2017-03-30 12:24:54 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 12:31:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95504aea9818ec4e593358d0373f...

Powered by Google App Engine
This is Rietveld 408576698