|
|
Created:
3 years, 11 months ago by kjellander_chromium Modified:
3 years, 10 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd binutils-aarch64-linux-gnu to support Linux ARM64 build.
This is needed to avoid AR errors in build/toolchain/gcc_ar_wrapper.py
during compile when building for Linux ARM64.
The size of thew new dependency is ~19MB on Linux.
BUG=684356, webrtc:7024
Review-Url: https://codereview.chromium.org/2650823010
Cr-Commit-Position: refs/heads/master@{#446656}
Committed: https://chromium.googlesource.com/chromium/src/+/74c7e4b3a075d01cb9f04b8c746fa8bc888ed768
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
kjellander@chromium.org changed reviewers: + mcgrathr@chromium.org, thakis@chromium.org
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
rs-lgtm
thakis@chromium.org changed reviewers: + apatole@nvidia.com
but adding apatole who worked arm64/linux , maybe they have additional insights. (I wonder if we should have an arm64-list instead of putting this in the 32-bit arm list)
On 2017/01/26 19:41:23, Nico wrote: > but adding apatole who worked arm64/linux , maybe they have additional insights. > > (I wonder if we should have an arm64-list instead of putting this in the 32-bit > arm list) Quick inputs, I remember we need binutils-aarch64-linux-gnu but not sure about the other addition, may be it gets automatically installed as part of binutils dependency. Infact I had thought of putting up a CL for this as few people had posted related compilation errors on personal emails, but somehow forgot to do it. And yes, I think we should have separate arm64 list. Will look more into this today and update in case i have any more inputs.
On 2017/01/27 06:35:56, apatole wrote: > On 2017/01/26 19:41:23, Nico wrote: > > but adding apatole who worked arm64/linux , maybe they have additional > insights. > > > > (I wonder if we should have an arm64-list instead of putting this in the > 32-bit > > arm list) > > Quick inputs, > I remember we need binutils-aarch64-linux-gnu but not sure about the other > addition, may be it gets automatically installed as part of binutils dependency. > Infact I had thought of putting up a CL for this as few people had posted > related compilation errors on personal emails, but somehow forgot to do it. > > And yes, I think we should have separate arm64 list. Will look more into this > today and update in case i have any more inputs. Sorry I overlooked some part of the change earlier and I thought we are adding two packages. LGTM.
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1485522339306730, "parent_rev": "45325144b2b61587c8eca0b2e78e30ca8b6874ea", "commit_rev": "74c7e4b3a075d01cb9f04b8c746fa8bc888ed768"}
Message was sent while issue was closed.
Description was changed from ========== Add binutils-aarch64-linux-gnu to support Linux ARM64 build. This is needed to avoid AR errors in build/toolchain/gcc_ar_wrapper.py during compile when building for Linux ARM64. The size of thew new dependency is ~19MB on Linux. BUG=684356,webrtc:7024 ========== to ========== Add binutils-aarch64-linux-gnu to support Linux ARM64 build. This is needed to avoid AR errors in build/toolchain/gcc_ar_wrapper.py during compile when building for Linux ARM64. The size of thew new dependency is ~19MB on Linux. BUG=684356,webrtc:7024 Review-Url: https://codereview.chromium.org/2650823010 Cr-Commit-Position: refs/heads/master@{#446656} Committed: https://chromium.googlesource.com/chromium/src/+/74c7e4b3a075d01cb9f04b8c746f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/74c7e4b3a075d01cb9f04b8c746f...
Message was sent while issue was closed.
On 2017/01/27 13:16:19, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/74c7e4b3a075d01cb9f04b8c746f... This is broken on Precise and Trusty: $ apt-cache search binutils-a binutils-arm-linux-gnueabi - GNU binary utilities, for arm-linux-gnueabi target binutils-arm-linux-gnueabihf - GNU binary utilities, for arm-linux-gnueabihf target binutils-avr - Binary utilities supporting Atmel's AVR targets
Message was sent while issue was closed.
On 2017/02/21 23:04:04, friedman wrote: > On 2017/01/27 13:16:19, commit-bot: I haz the power wrote: > > Committed patchset #1 (id:1) as > > > https://chromium.googlesource.com/chromium/src/+/74c7e4b3a075d01cb9f04b8c746f... > > This is broken on Precise and Trusty: > > $ apt-cache search binutils-a > binutils-arm-linux-gnueabi - GNU binary utilities, for arm-linux-gnueabi target > binutils-arm-linux-gnueabihf - GNU binary utilities, for arm-linux-gnueabihf > target > binutils-avr - Binary utilities supporting Atmel's AVR targets Sorry disregard that... non-up-to-date repo. |