Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 2650823010: Add binutils-aarch64-linux-gnu to support Linux ARM64 build. (Closed)

Created:
3 years, 11 months ago by kjellander_chromium
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add binutils-aarch64-linux-gnu to support Linux ARM64 build. This is needed to avoid AR errors in build/toolchain/gcc_ar_wrapper.py during compile when building for Linux ARM64. The size of thew new dependency is ~19MB on Linux. BUG=684356, webrtc:7024 Review-Url: https://codereview.chromium.org/2650823010 Cr-Commit-Position: refs/heads/master@{#446656} Committed: https://chromium.googlesource.com/chromium/src/+/74c7e4b3a075d01cb9f04b8c746fa8bc888ed768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
kjellander_chromium
3 years, 11 months ago (2017-01-26 09:04:41 UTC) #2
Roland McGrath
lgtm
3 years, 11 months ago (2017-01-26 19:31:19 UTC) #7
Nico
rs-lgtm
3 years, 11 months ago (2017-01-26 19:40:04 UTC) #8
Nico
but adding apatole who worked arm64/linux , maybe they have additional insights. (I wonder if ...
3 years, 11 months ago (2017-01-26 19:41:23 UTC) #10
apatole
On 2017/01/26 19:41:23, Nico wrote: > but adding apatole who worked arm64/linux , maybe they ...
3 years, 11 months ago (2017-01-27 06:35:56 UTC) #11
apatole
On 2017/01/27 06:35:56, apatole wrote: > On 2017/01/26 19:41:23, Nico wrote: > > but adding ...
3 years, 10 months ago (2017-01-27 12:41:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650823010/1
3 years, 10 months ago (2017-01-27 13:05:55 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/74c7e4b3a075d01cb9f04b8c746fa8bc888ed768
3 years, 10 months ago (2017-01-27 13:16:19 UTC) #17
friedman
On 2017/01/27 13:16:19, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 10 months ago (2017-02-21 23:04:04 UTC) #18
friedman
3 years, 10 months ago (2017-02-21 23:06:41 UTC) #19
Message was sent while issue was closed.
On 2017/02/21 23:04:04, friedman wrote:
> On 2017/01/27 13:16:19, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/74c7e4b3a075d01cb9f04b8c746f...
> 
> This is broken on Precise and Trusty:
> 
> $ apt-cache search binutils-a
> binutils-arm-linux-gnueabi - GNU binary utilities, for arm-linux-gnueabi
target
> binutils-arm-linux-gnueabihf - GNU binary utilities, for arm-linux-gnueabihf
> target
> binutils-avr - Binary utilities supporting Atmel's AVR targets

Sorry disregard that... non-up-to-date repo.

Powered by Google App Engine
This is Rietveld 408576698