Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 2790343002: Revert of [inspector] move console to builtins (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
Reviewers:
kozy, dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] move console to builtins (patchset #7 id:140001 of https://codereview.chromium.org/2785293002/ ) Reason for revert: http://crbug.com/v8/6198 Original issue's description: > [inspector] move console to builtins > > What will we get: > - console would be included into snapshot and allow us to reduce time that we spent in contextCreated function (~5 times faster), > - it allows us to make further small improvement of console methods, e.g. we can implement super quick return from console.assert if first argument is true, > - console calls are ~ 15% faster. > > BUG=v8:6175 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2785293002 > Cr-Original-Commit-Position: refs/heads/master@{#44353} > Committed: https://chromium.googlesource.com/v8/v8/+/55905f85d63d75aaa9313e51eb7bede754a8e41c > Review-Url: https://codereview.chromium.org/2785293002 > Cr-Commit-Position: refs/heads/master@{#44355} > Committed: https://chromium.googlesource.com/v8/v8/+/cc74ea0bc4fe4a71fa53d08b62cc18d15e01fbb3 TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6175 Review-Url: https://codereview.chromium.org/2790343002 Cr-Commit-Position: refs/heads/master@{#44358} Committed: https://chromium.googlesource.com/v8/v8/+/7c10795209f7ec6d0da717416e42c79bc228d27a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -389 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M include/v8.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/api.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D src/builtins/builtins-console.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M src/builtins/builtins-definitions.h View 1 chunk +0 lines, -25 lines 0 comments Download
M src/debug/debug-interface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/interface-types.h View 2 chunks +0 lines, -47 lines 0 comments Download
M src/inspector/inspected-context.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M src/inspector/v8-console.h View 3 chunks +25 lines, -32 lines 0 comments Download
M src/inspector/v8-console.cc View 22 chunks +125 lines, -58 lines 0 comments Download
M src/inspector/v8-inspector-impl.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M src/isolate.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/inspector/inspector-impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D test/inspector/runtime/console-spec.js View 1 chunk +0 lines, -51 lines 0 comments Download
D test/inspector/runtime/console-spec-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [inspector] move console to builtins
3 years, 8 months ago (2017-04-04 06:47:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790343002/1
3 years, 8 months ago (2017-04-04 06:47:58 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 06:48:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7c10795209f7ec6d0da717416e42c79bc22...

Powered by Google App Engine
This is Rietveld 408576698