Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: src/debug/interface-types.h

Issue 2790343002: Revert of [inspector] move console to builtins (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug-interface.h ('k') | src/inspector/inspected-context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/interface-types.h
diff --git a/src/debug/interface-types.h b/src/debug/interface-types.h
index 3f82fe6d768fcbb93a498a678f3598cc7f6bb1f1..82eb2f2abbc12e8dd42f40b2d4d86efc2275744c 100644
--- a/src/debug/interface-types.h
+++ b/src/debug/interface-types.h
@@ -9,15 +9,9 @@
#include <string>
#include <vector>
-#include "include/v8.h"
#include "src/globals.h"
namespace v8 {
-
-namespace internal {
-class BuiltinArguments;
-} // internal
-
namespace debug {
/**
@@ -96,47 +90,6 @@
BreakLocationType type_;
};
-class ConsoleCallArguments : private v8::FunctionCallbackInfo<v8::Value> {
- public:
- int Length() const { return v8::FunctionCallbackInfo<v8::Value>::Length(); }
- V8_INLINE Local<Value> operator[](int i) const {
- return v8::FunctionCallbackInfo<v8::Value>::operator[](i);
- }
-
- explicit ConsoleCallArguments(const v8::FunctionCallbackInfo<v8::Value>&);
- explicit ConsoleCallArguments(internal::BuiltinArguments&);
-};
-
-// v8::FunctionCallbackInfo could be used for getting arguments only. Calling
-// of any other getter will produce a crash.
-class ConsoleDelegate {
- public:
- virtual void Debug(const ConsoleCallArguments& args) {}
- virtual void Error(const ConsoleCallArguments& args) {}
- virtual void Info(const ConsoleCallArguments& args) {}
- virtual void Log(const ConsoleCallArguments& args) {}
- virtual void Warn(const ConsoleCallArguments& args) {}
- virtual void Dir(const ConsoleCallArguments& args) {}
- virtual void DirXml(const ConsoleCallArguments& args) {}
- virtual void Table(const ConsoleCallArguments& args) {}
- virtual void Trace(const ConsoleCallArguments& args) {}
- virtual void Group(const ConsoleCallArguments& args) {}
- virtual void GroupCollapsed(const ConsoleCallArguments& args) {}
- virtual void GroupEnd(const ConsoleCallArguments& args) {}
- virtual void Clear(const ConsoleCallArguments& args) {}
- virtual void Count(const ConsoleCallArguments& args) {}
- virtual void Assert(const ConsoleCallArguments& args) {}
- virtual void MarkTimeline(const ConsoleCallArguments& args) {}
- virtual void Profile(const ConsoleCallArguments& args) {}
- virtual void ProfileEnd(const ConsoleCallArguments& args) {}
- virtual void Timeline(const ConsoleCallArguments& args) {}
- virtual void TimelineEnd(const ConsoleCallArguments& args) {}
- virtual void Time(const ConsoleCallArguments& args) {}
- virtual void TimeEnd(const ConsoleCallArguments& args) {}
- virtual void TimeStamp(const ConsoleCallArguments& args) {}
- virtual ~ConsoleDelegate() = default;
-};
-
} // namespace debug
} // namespace v8
« no previous file with comments | « src/debug/debug-interface.h ('k') | src/inspector/inspected-context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698