Use PluginView type rather than FrameViewBase for v8 Script object.

Use PluginView type rather than FrameViewBase for v8 Script object.

BUG=637460
Review-Url: https://codereview.chromium.org/2790283002
Cr-Commit-Position: refs/heads/master@{#461646}
Committed: https://chromium.googlesource.com/chromium/src/+/e95714056f82a1a3ca21d29437b98b5821189d67

[joelhockey, 2017-04-03 22:34:59]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[joelhockey, 2017-04-03 22:35:13]

joelhockey@chromium.org changed reviewers:
+ slangley@chromium.org

[commit-bot: I haz the power, 2017-04-03 22:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[slangley, 2017-04-03 23:46:51]

lgtm

[commit-bot: I haz the power, 2017-04-04 00:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 00:14:16]

Dry run: This issue passed the CQ dry run.

[joelhockey, 2017-04-04 00:31:07]

joelhockey@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org

[joelhockey, 2017-04-04 00:31:07]

ptal haraken, dcheng

While I'm waiting for https://codereview.chromium.org/2764313002, I've found a
few small things I can still clean up.

[dglazkov, 2017-04-04 00:40:53]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2017-04-04 00:40:54]

lgtm

https://codereview.chromium.org/2790283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp (right):

https://codereview.chromium.org/2790283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp:351: return layoutPart
&& layoutPart->frameViewBase() &&
I find this rather long and unwieldy. Maybe switch back to if/return?

[joelhockey, 2017-04-04 01:34:44]

Thanks Dimitri.

https://codereview.chromium.org/2790283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp (right):

https://codereview.chromium.org/2790283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp:351: return layoutPart
&& layoutPart->frameViewBase() &&
On 2017/04/04 at 00:40:54, dglazkov wrote:
> I find this rather long and unwieldy. Maybe switch back to if/return?

Done

[joelhockey, 2017-04-04 01:34:49]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-04-04 01:34:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
slangley@chromium.org, dglazkov@chromium.org
Link to the patchset: https://codereview.chromium.org/2790283002/#ps20001
(title: "Format if/return as per comment")

[commit-bot: I haz the power, 2017-04-04 01:35:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-04-04 01:55:40]

LGTM

[commit-bot: I haz the power, 2017-04-04 05:15:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 05:15:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[joelhockey, 2017-04-04 05:20:18]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-04-04 05:20:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-04-04 06:28:04]

lgtm

[commit-bot: I haz the power, 2017-04-04 06:43:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491283218734550,
"parent_rev": "35508f05e62ec481dfa71cde31cb1c9aa5492b17", "commit_rev":
"e95714056f82a1a3ca21d29437b98b5821189d67"}

[commit-bot: I haz the power, 2017-04-04 06:44:25]

Description was changed from

==========
Use PluginView type rather than FrameViewBase for v8 Script object.

BUG=637460
==========

to

==========
Use PluginView type rather than FrameViewBase for v8 Script object.

BUG=637460

Review-Url: https://codereview.chromium.org/2790283002
Cr-Commit-Position: refs/heads/master@{#461646}
Committed:
https://chromium.googlesource.com/chromium/src/+/e95714056f82a1a3ca21d29437b9...
==========

[commit-bot: I haz the power, 2017-04-04 06:44:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e95714056f82a1a3ca21d29437b9...