Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Issue 2790283002: Use PluginView type rather than FrameViewBase for v8 Script object. (Closed)
Patch Set: Format if/return as per comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
index 092a13467332e7f472cb635ffa612876b87cf713..ad4c181cb7a93334eabab95ad4a8c56bb0fb2a82 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
@@ -182,15 +182,9 @@ void ScriptController::disableEval(const String& errorMessage) {
}
PassRefPtr<SharedPersistent<v8::Object>> ScriptController::createPluginWrapper(
- FrameViewBase* frameViewBase) {
- DCHECK(frameViewBase);
-
- if (!frameViewBase->isPluginView())
- return nullptr;
-
+ PluginView& plugin) {
v8::HandleScope handleScope(isolate());
- v8::Local<v8::Object> scriptableObject =
- toPluginView(frameViewBase)->scriptableObject(isolate());
+ v8::Local<v8::Object> scriptableObject = plugin.scriptableObject(isolate());
if (scriptableObject.IsEmpty())
return nullptr;
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptController.h ('k') | third_party/WebKit/Source/core/html/HTMLPlugInElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698