Issue 2790153002: Fix possible Strictmode crash when initializing non-presenting GVR context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2790153002: Fix possible Strictmode crash when initializing non-presenting GVR context. (Closed)

Created:
3 years, 8 months ago by mthiesse

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Fix possible Strictmode crash when initializing non-presenting GVR context. BUG=707278 Review-Url: https://codereview.chromium.org/2788183002 Cr-Commit-Position: refs/heads/master@{#461198} (cherry picked from commit 09533657d232cd63351a1bceb6afbb507e414efc) Review-Url: https://codereview.chromium.org/2790153002 . Cr-Commit-Position: refs/branch-heads/3029@{#543} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/fa06f379a8f522af6c94e551139fd2127ac78c7c

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java	View		2 chunks	+8 lines, -1 line	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

mthiesse

3 years, 8 months ago (2017-04-03 14:34:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fa06f379a8f522af6c94e551139fd2127ac78c7c.