Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2788183002: Fix possible Strictmode crash when initializing non-presenting GVR context. (Closed)

Created:
3 years, 8 months ago by mthiesse
Modified:
3 years, 8 months ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix possible Strictmode crash when initializing non-presenting GVR context. BUG=707278 Review-Url: https://codereview.chromium.org/2788183002 Cr-Commit-Position: refs/heads/master@{#461198} Committed: https://chromium.googlesource.com/chromium/src/+/09533657d232cd63351a1bceb6afbb507e414efc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL
3 years, 8 months ago (2017-03-31 17:29:13 UTC) #2
bshe
On 2017/03/31 17:29:13, mthiesse wrote: > PTAL lgtm
3 years, 8 months ago (2017-03-31 18:50:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788183002/1
3 years, 8 months ago (2017-03-31 19:20:25 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 20:08:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/09533657d232cd63351a1bceb6af...

Powered by Google App Engine
This is Rietveld 408576698