Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2790113002: [LargeIconService] Update parameters for Google server (Closed)

Created:
3 years, 8 months ago by jkrcal
Modified:
3 years, 8 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LargeIconService] Update parameters for Google server This CL makes two small changes: - Fix two typos/omissions in the URL format so that it actually works as intended. - Change to sizes that we ask for. As the only (experimental) application for M59 is for publisher favicons which are at most 64px on high-end hardware, we decrease the sizes for the time being to save users' data as well as server band-width. BUG=644102 Review-Url: https://codereview.chromium.org/2790113002 Cr-Commit-Position: refs/heads/master@{#461650} Committed: https://chromium.googlesource.com/chromium/src/+/e7ce66c1137284f0fd3b9d6a17df4802c2ac875c

Patch Set 1 #

Patch Set 2 : Update unit-tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M components/favicon/core/large_icon_service.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/favicon/core/large_icon_service_unittest.cc View 1 4 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jkrcal
Peter, could you PTAL?
3 years, 8 months ago (2017-04-03 12:55:30 UTC) #4
pkotwicz
lgtm
3 years, 8 months ago (2017-04-04 02:36:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790113002/20001
3 years, 8 months ago (2017-04-04 07:02:59 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 07:08:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e7ce66c1137284f0fd3b9d6a17df...

Powered by Google App Engine
This is Rietveld 408576698