Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: components/favicon/core/large_icon_service_unittest.cc

Issue 2790113002: [LargeIconService] Update parameters for Google server (Closed)
Patch Set: Update unit-tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/large_icon_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/large_icon_service_unittest.cc
diff --git a/components/favicon/core/large_icon_service_unittest.cc b/components/favicon/core/large_icon_service_unittest.cc
index fd9cfa4df6bd53efd5ccef0cea22f9f95c75f7b6..51d43fafc7982dcdec3e7554688c6d0235bff63c 100644
--- a/components/favicon/core/large_icon_service_unittest.cc
+++ b/components/favicon/core/large_icon_service_unittest.cc
@@ -269,8 +269,8 @@ TEST_F(LargeIconServiceTest, FallbackSinceTooPicky) {
TEST_F(LargeIconServiceTest, ShouldGetFromGoogleServer) {
const GURL kExpectedServerUrl(
- "https://t0.gstatic.com/faviconV2?user=chrome&drop_404_icon=true"
- "&size=192&min_size=42&max_size=256&fallback_opts=TYPE"
+ "https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
+ "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE"
"&url=http://www.example.com/");
EXPECT_CALL(mock_favicon_service_, UnableToDownloadFavicon(_)).Times(0);
@@ -296,8 +296,8 @@ TEST_F(LargeIconServiceTest, ShouldGetFromGoogleServer) {
TEST_F(LargeIconServiceTest, ShouldTrimQueryParametersForGoogleServer) {
const GURL kDummyUrlWithQuery("http://www.example.com?foo=1");
const GURL kExpectedServerUrl(
- "https://t0.gstatic.com/faviconV2?user=chrome&drop_404_icon=true"
- "&size=192&min_size=42&max_size=256&fallback_opts=TYPE"
+ "https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
+ "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE"
"&url=http://www.example.com/");
EXPECT_CALL(*mock_image_fetcher_,
@@ -335,8 +335,8 @@ TEST_F(LargeIconServiceTest, ShouldNotQueryGoogleServerIfInvalidScheme) {
TEST_F(LargeIconServiceTest, ShouldReportUnavailableIfFetchFromServerFails) {
const GURL kDummyUrlWithQuery("http://www.example.com?foo=1");
const GURL kExpectedServerUrl(
- "https://t0.gstatic.com/faviconV2?user=chrome&drop_404_icon=true"
- "&size=192&min_size=42&max_size=256&fallback_opts=TYPE"
+ "https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
+ "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE"
"&url=http://www.example.com/");
EXPECT_CALL(mock_favicon_service_, SetLastResortFavicons(_, _, _, _, _))
@@ -358,11 +358,12 @@ TEST_F(LargeIconServiceTest, ShouldReportUnavailableIfFetchFromServerFails) {
}
TEST_F(LargeIconServiceTest, ShoutNotGetFromGoogleServerIfUnavailable) {
- ON_CALL(mock_favicon_service_,
- WasUnableToDownloadFavicon(GURL(
- "https://t0.gstatic.com/faviconV2?user=chrome&drop_404_icon=true"
- "&size=192&min_size=42&max_size=256&fallback_opts=TYPE"
- "&url=http://www.example.com/")))
+ ON_CALL(
+ mock_favicon_service_,
+ WasUnableToDownloadFavicon(GURL(
+ "https://t0.gstatic.com/faviconV2?client=chrome&drop_404_icon=true"
+ "&size=64&min_size=42&max_size=128&fallback_opts=TYPE,SIZE"
+ "&url=http://www.example.com/")))
.WillByDefault(Return(true));
EXPECT_CALL(mock_favicon_service_, UnableToDownloadFavicon(_)).Times(0);
« no previous file with comments | « components/favicon/core/large_icon_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698