Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2790083002: Add a virtual destructor for InterpolationType (Closed)

Created:
3 years, 8 months ago by meade_UTC10
Modified:
3 years, 8 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a virtual destructor for InterpolationType Without this, in some cases we get Illegal Instruction crashes. BUG=702695 Review-Url: https://codereview.chromium.org/2790083002 Cr-Commit-Position: refs/heads/master@{#461410} Committed: https://chromium.googlesource.com/chromium/src/+/fb80b96a036920cd61a7e2cea33a1e797bc96816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/animation/InterpolationType.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
meade_UTC10
3 years, 8 months ago (2017-04-03 07:55:08 UTC) #2
alancutter (OOO until 2018)
lgtm
3 years, 8 months ago (2017-04-03 12:08:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790083002/1
3 years, 8 months ago (2017-04-03 12:08:52 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 12:14:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb80b96a036920cd61a7e2cea33a...

Powered by Google App Engine
This is Rietveld 408576698